Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.8] bpo-38304: Remove PyConfig.struct_size #16500

Merged
merged 1 commit into from
Sep 30, 2019
Merged

[3.8] bpo-38304: Remove PyConfig.struct_size #16500

merged 1 commit into from
Sep 30, 2019

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Sep 30, 2019 •
edited by bedevere-bot
Loading

@vstinner vstinner changed the title bpo-38304: Remove PyConfig.struct_size [3.8] bpo-38304: Remove PyConfig.struct_size Sep 30, 2019
@vstinner
Copy link
Member Author

If this change is merged, it should be forward-ported to the master branch.

@vstinner
Copy link
Member Author

See https://mail.python.org/archives/list/[email protected]/thread/C7Z2NA2DTM3DLOZCFQAK5A2WFYO3PHHX/ and https://bugs.python.org/issue38326 for the rationale and discussion.

@vstinner vstinner mentioned this pull request Sep 30, 2019
Closed
pitrou
pitrou approved these changes Sep 30, 2019
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me. Leaves us time to discuss any further change without hurrying.

@vstinner
Copy link
Member Author

+1 from me. Leaves us time to discuss any further change without hurrying.

I'm a strong believer that a "stable ABI world" is possible... But we cannot implement everything today before 3.8.0rc1 final cut :-)

It seems like we need more time to properly design the overall use story "provide a stable ABI for embedded Python". PyConfig is just a small piece. I didn't notice that vim is directly linked to libpython3.7.so for example.

@pitrou
Copy link
Member

pitrou commented Sep 30, 2019

The "struct size" field didn't define a stable ABI, so it's moot anyway.

@vstinner
Copy link
Member Author

See also PR #16496: @ncoghlan proposes to replace struct_size with header_version.

@brettcannon brettcannon removed their request for review September 30, 2019 22:13
ncoghlan
ncoghlan approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Victor. This update did convince that a stable embedding APi is more plausible than I previously thought it was, but just before an RC isn't the right time for us to be designing the initial pieces of that feature :)

@ncoghlan ncoghlan merged commit bdace21 into python:3.8 Sep 30, 2019
@vstinner vstinner deleted the config_remove_struct_size branch October 1, 2019 08:27
vstinner added a commit that referenced this pull request Oct 1, 2019
@vstinner
bpo-38304: Remove PyConfig.struct_size (GH-16500) (GH-16508)
3c30a76 
For now, we'll rely on the fact that the config structures aren't covered by the stable ABI.

We may revisit this in the future if we further explore the idea of offering a stable embedding API.

(cherry picked from commit bdace21)
@vstinner vstinner mentioned this pull request Oct 1, 2019
Merged
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@vstinner
bpo-38304: Remove PyConfig.struct_size (pythonGH-16500) (pythonGH-16508)
502eb92 
For now, we'll rely on the fact that the config structures aren't covered by the stable ABI.

We may revisit this in the future if we further explore the idea of offering a stable embedding API.

(cherry picked from commit bdace21)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncoghlan ncoghlan ncoghlan approved these changes

@pitrou pitrou pitrou approved these changes

@encukou encukou Awaiting requested review from encukou encukou is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vstinner @pitrou @ncoghlan @the-knights-who-say-ni @bedevere-bot