bpo-29520: Fix deprecation warning from 'defindex' template #165
Conversation
methane
force-pushed
the
support-new-sphinx
branch
from
d8de985
to
1dbe103
Compare
| <h1>{{ docstitle|e }}</h1> | ||
| <p> | ||
| {% trans %}Welcome! This is the documentation for Python {{ release }}{% endtrans %} | ||
| </p> |
There was a problem hiding this comment.
I think this paragraph is redundant. But it's out of scope of the issue.
There was a problem hiding this comment.
There are minor change. ", last updated Feb 19, 2017." part is removed.
I remove it because "Last update: " is in footer. It's duplicated information.
|
I think the main advantage I see to @ultimatecoder's approach in #170 is that that doesn't require changing the minimum Sphinx version. Perhaps it would make sense to go with this PR and the newer Sphinx requirement for 3.7+, while using the approach in #170 for the maintenance branches? |
There was a problem hiding this comment.
FWIW, I prefer this over #170. defindex comes from the very early days of Sphinx (pre 1.0 IIRC) and it was kept for backward compatibility reasons over the years. Since it's easy to drop it I don't think we should maintain a copy of defindex.html in CPython codebase.
And since we use venv to build the docs it's easy to upgrade the Sphinx version installed.
|
@ncoghlan I update minimum version because no one test it. sphinx-doc/sphinx#2986 (comment)
|
|
I confirmed sphinx 1.2.3 can build html without any warnings. |
|
That's great! Assuming you've also verified the HTML output of Thanks. |
* allow multiline debug expresisons * check whether the bracket is top-level * fix punctuation to top-level : * inline f-string level check to callsites * free fstring buffers at the end# * fix leaked buffer on realloc#
Confirmed with Sphinx 1.3.6 and 1.5.2
[bpo-29520]