-
-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-38168: Fix possible refleaks in setint() of mmapmodule.c #16136
Conversation
Could you reproduce with a test? and via this command?
replace test_XYZ by a test where you test the memory leak. |
I have the same question too, but i found some PR or bpo no regression test against it :( |
In current code, if Another way is to use |
Agree.
I review the PyModule_AddIntMacro code, looks your are right. But as your said, it MAYBE a bit slower. |
I would suggest use "possible" in the title, "Fix possible refleaks..." |
done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for this tiny and clear fix, which also hard to reproduce, it's okay to omit test.
Thanks @shihai1991 for the PR, and @zhangyangyu for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
GH-16174 is a backport of this pull request to the 3.8 branch. |
GH-16175 is a backport of this pull request to the 3.7 branch. |
(cherry picked from commit 56a4514) Co-authored-by: Hai Shi <[email protected]>
…H-16136) (GH-16174) (cherry picked from commit 56a4514) Co-authored-by: Hai Shi <[email protected]> https://bugs.python.org/issue38168 Automerge-Triggered-By: @zhangyangyu
…H-16136) (GH-16175) (cherry picked from commit 56a4514) Co-authored-by: Hai Shi <[email protected]> Automerge-Triggered-By: @zhangyangyu
Thanks @shihai1991 for the PR, and @zhangyangyu for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7. |
Sorry, @shihai1991 and @zhangyangyu, I could not cleanly backport this to |
…H-16136) (cherry picked from commit 56a4514) Co-authored-by: Hai Shi [email protected] https://bugs.python.org/issue38168
GH-16176 is a backport of this pull request to the 2.7 branch. |
|
…H-16136) (GH-16176) (cherry picked from commit 56a4514) Co-authored-by: Hai Shi [email protected] https://bugs.python.org/issue38168
https://bugs.python.org/issue38168