-
-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-38144: Add the root_dir and dir_fd parameters in glob.glob(). #16075
Merged
serhiy-storchaka
merged 11 commits into
python:master
from
serhiy-storchaka:glob-root_dir-dir_fd
Jun 18, 2020
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
30bd913
bpo-38144: Add the root_dir and dir_fd parameters in glob.glob().
serhiy-storchaka 8497742
Remove debug code.
serhiy-storchaka 4727de4
Add glob and iglob in os.supports_dir_fd.
serhiy-storchaka 62d025d
Use optional os.O_DIRECTORY only if available.
serhiy-storchaka fd5ae14
Try to fix tests on Windows.
serhiy-storchaka 17ed9a3
Merge branch 'master' into glob-root_dir-dir_fd
serhiy-storchaka 730e167
Merge branch 'master' into glob-root_dir-dir_fd
serhiy-storchaka 51daadc
Merge branch 'master' into glob-root_dir-dir_fd
serhiy-storchaka 798f496
Rewrap tests.
serhiy-storchaka 2442c47
Merge branch 'master' into glob-root_dir-dir_fd
serhiy-storchaka 1b5a380
Do not add glob in os.supports_dir_fd.
serhiy-storchaka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
Misc/NEWS.d/next/Library/2019-09-12-21-34-03.bpo-38144.8uQCdd.rst
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Added the *root_dir* and *dir_fd* parameters in :func:`glob.glob`. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this comment is necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not? It explains why the special case was added.
Or maybe you can suggest better wording?