Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-15542: Documentation incorrectly suggests __init__ called after direct __new__ call #15478

Merged
merged 3 commits into from
Aug 26, 2019

Conversation

nanjekyejoannah
Copy link
Contributor

@nanjekyejoannah nanjekyejoannah commented Aug 24, 2019

Co-Authored by : Aaron.Staley

Clarify data model documentation.

cc @cjerdonek

https://bugs.python.org/issue15542

@nanjekyejoannah
Copy link
Contributor Author

nanjekyejoannah commented Aug 24, 2019

@willingc , help me apply the skip news entry label on this PR.

@rhettinger rhettinger self-assigned this Aug 25, 2019
Doc/reference/datamodel.rst Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@nanjekyejoannah
Copy link
Contributor Author

I have made the requested changes; please review again .

@bedevere-bot
Copy link

Thanks for making the requested changes!

@rhettinger: please review the changes made to this pull request.

Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks as if the requested changes are applied. Thanks @nanjekyejoannah and Raymond.

@rhettinger rhettinger merged commit 6b16d93 into python:master Aug 26, 2019
@miss-islington
Copy link
Contributor

Thanks @nanjekyejoannah for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-15506 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 26, 2019
…irect __new__ call (pythonGH-15478)

(cherry picked from commit 6b16d93)

Co-authored-by: Joannah Nanjekye <[email protected]>
rhettinger pushed a commit that referenced this pull request Aug 26, 2019
…irect __new__ call (GH-15478) (GH-15506)

(cherry picked from commit 6b16d93)

Co-authored-by: Joannah Nanjekye <[email protected]>
@nanjekyejoannah nanjekyejoannah deleted the issue15542 branch August 26, 2019 10:32
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants