-
-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-15542: Documentation incorrectly suggests __init__ called after direct __new__ call #15478
Conversation
@willingc , help me apply the skip news entry label on this PR. |
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
I have made the requested changes; please review again . |
Thanks for making the requested changes! @rhettinger: please review the changes made to this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks as if the requested changes are applied. Thanks @nanjekyejoannah and Raymond.
Thanks @nanjekyejoannah for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
GH-15506 is a backport of this pull request to the 3.8 branch. |
…irect __new__ call (pythonGH-15478) (cherry picked from commit 6b16d93) Co-authored-by: Joannah Nanjekye <[email protected]>
…irect __new__ call (GH-15478) (GH-15506) (cherry picked from commit 6b16d93) Co-authored-by: Joannah Nanjekye <[email protected]>
…irect __new__ call (pythonGH-15478)
…irect __new__ call (pythonGH-15478)
…irect __new__ call (pythonGH-15478)
Co-Authored by : Aaron.Staley
Clarify data model documentation.
cc @cjerdonek
https://bugs.python.org/issue15542