bpo-16637: libpython: interpret string as integer literal #15232
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
Tools/gdb/libpython.py
Outdated
| @@ -1392,7 +1392,7 @@ def write_repr(self, out, visited): | |||
|
|
|||
|
|
|||
| def int_from_int(gdbval): | |||
| return int(str(gdbval)) | |||
| return int(str(gdbval), 0) | |||
There was a problem hiding this comment.
Can one not simply call int on integer-type GDB values?
There was a problem hiding this comment.
You mean something like
| return int(str(gdbval), 0) | |
| return int(gdbval.cast(gdb.lookup_type('long'))) |
?
There was a problem hiding this comment.
Yes, but do you have to do the cast?
There was a problem hiding this comment.
I think so - but to be sure I have to verify it. Will update my branch if it works.
There was a problem hiding this comment.
I've updated my branch. Seems a simple int call is enough - thanks (I assume this only holds if the gdbvalue has the right type).
This fixes the exception '`ValueError: invalid literal for int() with base 10` if `str(gdbval)` returns a hexadecimal value (e.g. '0xa0'). This is the case if the output-radix is set to 16 in gdb. See https://sourceware.org/gdb/onlinedocs/gdb/Numbers.html for more information.
|
Thanks @marc1006 for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
GH-16345 is a backport of this pull request to the 3.8 branch. |
…dbvalue (GH-15232) This fixes the exception '`ValueError: invalid literal for int() with base 10` if `str(gdbval)` returns a hexadecimal value (e.g. '0xa0'). This is the case if the output-radix is set to 16 in gdb. See https://sourceware.org/gdb/onlinedocs/gdb/Numbers.html for more information. (cherry picked from commit 6f53d34) Co-authored-by: Marc Hartmayer <[email protected]>
This fixes the exception
ValueError: invalid literal for int() with base 10if
str(gdbval)returns a hexadecimal value (e.g. '0xa0').See https://docs.python.org/3/library/functions.html#int for more information.
https://bugs.python.org/issue16637