[3.8] bpo-37530: simplify, optimize and clean up IDLE code context (GH-14675) #14807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…H-14675) * Only create CodeContext instances for "real" editors windows, but not e.g. shell or output windows. * Remove configuration update Tk event fired every second, by having the editor window ask its code context widget to update when necessary, i.e. upon font or highlighting updates. * When code context isn't being shown, avoid having a Tk event fired every 100ms to check whether the code context needs to be updated. * Use the editor window's getlineno() method where applicable. * Update font of the code context widget before the main text widget (cherry picked from commit 7036e1d) Co-authored-by: Tal Einat <[email protected]>
|
@taleinat: Status check is done, and it's a success ✅ . |
taleinat
approved these changes
Jul 17, 2019
|
@taleinat: Status check is done, and it's a success ✅ . |
1 similar comment
|
@taleinat: Status check is done, and it's a success ✅ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not e.g. shell or output windows.
the editor window ask its code context widget to update when
necessary, i.e. upon font or highlighting updates.
every 100ms to check whether the code context needs to be updated.
(cherry picked from commit 7036e1d)
Co-authored-by: Tal Einat [email protected]
https://bugs.python.org/issue37530