bpo-30281: fix the default value for stop in PySlice_Unpack() #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangyangyu
added
type-bug
|
@zhangyangyu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mdickinson, @benjaminp and @serhiy-storchaka to be potential reviewers. |
|
@serhiy-storchaka , do we need to change the doc and comment from |
|
ping @serhiy-storchaka |
|
Yes, I think it is worth to update the doc and the comment in ceval.c (but not the comment in PySlice_Unpack). |
serhiy-storchaka
approved these changes
May 10, 2017
zhangyangyu
added a commit
to zhangyangyu/cpython
that referenced
this pull request
May 10, 2017
zhangyangyu
added a commit
to zhangyangyu/cpython
that referenced
this pull request
May 10, 2017
zhangyangyu
added a commit
to zhangyangyu/cpython
that referenced
this pull request
May 10, 2017
zhangyangyu
added a commit
that referenced
this pull request
May 10, 2017
zhangyangyu
added a commit
that referenced
this pull request
May 10, 2017
zhangyangyu
added a commit
that referenced
this pull request
May 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.