Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-19696: Move threaded_import_hangers #14655

Merged
merged 4 commits into from
Jul 12, 2019
Merged

bpo-19696: Move threaded_import_hangers #14655

merged 4 commits into from
Jul 12, 2019

Conversation

aeros
Copy link
Contributor

@aeros aeros commented Jul 9, 2019 •
edited by brettcannon
Loading

Move threaded_import_hangers, a dependency of test_threaded_import, to the directory test_importlib/. Also update the import references for threaded_import_hangers in test_threaded_import.

https://bugs.python.org/issue19696

@aeros
Copy link
Contributor Author

aeros commented Jul 9, 2019 •
edited
Loading

Since the tests in the previous iteration of this PR failed (#14642), I made sure to run the tests as described in https://devguide.python.org/runtests/#runtests and ran make patchcheck. As an additional layer, I'll leave this PR as a draft until all of the integration tests are passing so that the code owners/reviewers are not spammed with notifications.

@aeros aeros marked this pull request as ready for review July 9, 2019 04:47
@miss-islington miss-islington merged commit a65c977 into python:master Jul 12, 2019
@brettcannon
Copy link
Member

@aeros167 thanks! Just an FYI, I tweaked the tense of your message to match the style we use in commit messages.

@aeros
Copy link
Contributor Author

aeros commented Jul 12, 2019

@brettcannon No problem! Is there somewhere in the devguide you would recommend referring to for the preferred commit message styling?

@aeros
Copy link
Contributor Author

aeros commented Jul 12, 2019 •
edited
Loading

Never mind, I found a relevant section on the devguide and a link to an external guide https://chris.beams.io/posts/git-commit/. I'll be sure to check them out.

@aeros aeros deleted the move-threaded_import_hangers branch July 12, 2019 22:36
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@aeros @lisroach
bpo-19696: Move threaded_import_hangers (pythonGH-14655)
df7a3a0 
Move `threaded_import_hangers`, a dependency of `test_threaded_import`, to the directory `test_importlib/`. Also update the import references for `threaded_import_hangers` in `test_threaded_import`.





https://bugs.python.org/issue19696
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@aeros @DinoV
bpo-19696: Move threaded_import_hangers (pythonGH-14655)
2832feb 
Move `threaded_import_hangers`, a dependency of `test_threaded_import`, to the directory `test_importlib/`. Also update the import references for `threaded_import_hangers` in `test_threaded_import`.





https://bugs.python.org/issue19696
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon brettcannon approved these changes

@encukou encukou Awaiting requested review from encukou

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

@ncoghlan ncoghlan Awaiting requested review from ncoghlan

@warsaw warsaw Awaiting requested review from warsaw

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aeros @brettcannon @the-knights-who-say-ni @bedevere-bot @miss-islington