bpo-29412: Fix indexError when parsing a header value ending unexpectedly #14387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er_value_parser.py and created tests in test__header_value_parser.py for CFWS.
|
To mention this borrows a test case from GH-6907 (which seeems to be abandoned, which is why I am proposing this new PR to override that). The fix however is different than GH-6907, which is why I haven't added a |
Also, modify the testcase.
maxking
force-pushed
the
gh-6907-2
branch
2 times, most recently
from
2941cb3
to
e28cbc9
Compare
mangrisano
approved these changes
Jun 26, 2019
maxking
changed the title
warsaw
reviewed
Jun 26, 2019
| @@ -1360,6 +1360,9 @@ def get_word(value): | |||
| leader, value = get_cfws(value) | |||
| else: | |||
| leader = None | |||
| if not value: | |||
There was a problem hiding this comment.
Do you want to catch all false-y values or just None?
There was a problem hiding this comment.
I want to catch None and empty string '' values, both of which could cause IndexError when running value[0]. It could also be caused by empty list, empty tuple etc etc, but I don't think value can be of those datatypes.
Remove implicit concatenation of strings and move the string to next line so that it can fit properly under 79 chars.
warsaw
approved these changes
Jun 26, 2019
|
I'm assuming this needs backporting to 3.7 and 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 26, 2019
…edly (pythonGH-14387) * patched string index out of range error in get_word function of _header_value_parser.py and created tests in test__header_value_parser.py for CFWS. * Raise HeaderParseError instead of continuing when parsing a word. (cherry picked from commit 7213df7) Co-authored-by: Abhilash Raj <[email protected]>
|
GH-14411 is a backport of this pull request to the 3.8 branch. |
|
GH-14412 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 26, 2019
…edly (pythonGH-14387) * patched string index out of range error in get_word function of _header_value_parser.py and created tests in test__header_value_parser.py for CFWS. * Raise HeaderParseError instead of continuing when parsing a word. (cherry picked from commit 7213df7) Co-authored-by: Abhilash Raj <[email protected]>
warsaw
pushed a commit
that referenced
this pull request
Jun 26, 2019
…edly (GH-14387) (GH-14412) * patched string index out of range error in get_word function of _header_value_parser.py and created tests in test__header_value_parser.py for CFWS. * Raise HeaderParseError instead of continuing when parsing a word. (cherry picked from commit 7213df7) Co-authored-by: Abhilash Raj <[email protected]>
warsaw
pushed a commit
that referenced
this pull request
Jun 26, 2019
…edly (GH-14387) (GH-14411) * patched string index out of range error in get_word function of _header_value_parser.py and created tests in test__header_value_parser.py for CFWS. * Raise HeaderParseError instead of continuing when parsing a word. (cherry picked from commit 7213df7) Co-authored-by: Abhilash Raj <[email protected]>
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
…edly (pythonGH-14387) * patched string index out of range error in get_word function of _header_value_parser.py and created tests in test__header_value_parser.py for CFWS. * Raise HeaderParseError instead of continuing when parsing a word.
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
…edly (pythonGH-14387) * patched string index out of range error in get_word function of _header_value_parser.py and created tests in test__header_value_parser.py for CFWS. * Raise HeaderParseError instead of continuing when parsing a word.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing a word, if the value is None, we should raise
HeaderParseErrorinstead of continuing silently. This helps fix the IndexError.Part of the patch is from GH-6907, so thanks to @TyrannosourceExe.
https://bugs.python.org/issue29412