Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing single quote in io.TextIOWrapper.reconfigure documentation #14246

Merged

Conversation

Harmon758
Copy link
Contributor

@Harmon758 Harmon758 commented Jun 19, 2019

Add a missing single quote character in the documentation for io.TextIOWrapper.reconfigure.

@miss-islington
Copy link
Contributor

Thanks @Harmon758 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@bedevere-bot
Copy link

GH-14247 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 19, 2019
pythonGH-14246)

Add a missing single quote character in the documentation for `io.TextIOWrapper.reconfigure`.
(cherry picked from commit 35068bd)

Co-authored-by: Harmon <[email protected]>
@Mariatta
Copy link
Member

Thanks for noticing and fixing it! 🌮

@Mariatta Mariatta added needs backport to 3.8 only security fixes and removed needs backport to 3.8 only security fixes labels Jun 19, 2019
@miss-islington
Copy link
Contributor

Thanks @Harmon758 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 19, 2019
pythonGH-14246)

Add a missing single quote character in the documentation for `io.TextIOWrapper.reconfigure`.
(cherry picked from commit 35068bd)

Co-authored-by: Harmon <[email protected]>
@bedevere-bot
Copy link

GH-14248 is a backport of this pull request to the 3.8 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Jun 19, 2019
@Harmon758 Harmon758 deleted the textiowrapper.reconfigure-doc-fix branch June 19, 2019 21:02
miss-islington added a commit that referenced this pull request Jun 19, 2019
GH-14246)

Add a missing single quote character in the documentation for `io.TextIOWrapper.reconfigure`.
(cherry picked from commit 35068bd)

Co-authored-by: Harmon <[email protected]>
miss-islington added a commit that referenced this pull request Jun 19, 2019
GH-14246)

Add a missing single quote character in the documentation for `io.TextIOWrapper.reconfigure`.
(cherry picked from commit 35068bd)

Co-authored-by: Harmon <[email protected]>
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request Jun 21, 2019
* master: (599 commits)
  Docs: Improved phrasing (pythonGH-14069)
  Remove redundant if check from optional argument function in argparse. (pythonGH-8766)
  bpo-37289: Add a test for if with ifexpr in the peephole optimiser to detect regressions (pythonGH-14127)
  Update What's New in Python 3.9 (pythonGH-14253)
  bpo-36511: Improve ARM32 buildbot scripts (pythonGH-14251)
  bpo-37151: remove _PyCFunction_FastCallDict (pythonGH-14269)
  Fix typo, 'widger' -> 'widget', in idlelib/tree.py (pythonGH-14263)
  Fix bpo number in News file. (pythonGH-14260)
  bpo-37342: Fix the incorrect nb_index's type in typeobj documentation (pythonGH-14241)
  Update What's New in Python 3.8 (pythonGH-14239)
  bpo-36710: Use tstate in pylifecycle.c (pythonGH-14249)
  Add missing single quote in io.TextIOWrapper.reconfigure documentation (pythonGH-14246)
  bpo-36511: Add buildbot scripts and fix tests for Windows ARM32 buildbot (pythonGH-13454)
  bpo-37333: Ensure IncludeTkinter has a value (pythonGH-14240)
  bpo-37331: Clarify format of socket handler messages in the documentation. (pythonGH-14234)
  bpo-37258: Not a bug, but added a unit test and updated documentation. (pythonGH-14229)
  bpo-36710: Remove PyImport_Cleanup() function (pythonGH-14221)
  Fix name of '\0'. (pythonGH-14222)
  bpo-36710: Add tstate parameter in import.c (pythonGH-14218)
  Document typing.ForwardRef (pythonGH-14216)
  ...
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
pythonGH-14246)

Add a missing single quote character in the documentation for `io.TextIOWrapper.reconfigure`.
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
pythonGH-14246)

Add a missing single quote character in the documentation for `io.TextIOWrapper.reconfigure`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants