bpo-37312: Remove _dummy_thread and dummy_threading modules #14143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tirkarthi
reviewed
Jun 17, 2019
There was a problem hiding this comment.
There are two more references. It seems there is a fixer in 2to3 to convert dummy_thread to _dummy_thread. Since it's being removed I guess its good to remove the import related fixes too.
Lib/lib2to3/fixes/fix_imports.py:35: 'dummy_thread': '_dummy_thread',
Lib/_compat_pickle.py:31: 'dummy_thread': '_dummy_thread',
2to3 renames dummy_thread to _dummy_thread but running the fixed program with this PR throws ImportError
➜ cpython git:(pr_14143) cat /tmp/foo.py
import dummy_thread
➜ cpython git:(pr_14143) ./python.exe Tools/scripts/2to3 /tmp/foo.py
RefactoringTool: Skipping optional fixer: buffer
RefactoringTool: Skipping optional fixer: idioms
RefactoringTool: Skipping optional fixer: set_literal
RefactoringTool: Skipping optional fixer: ws_comma
RefactoringTool: Refactored /tmp/foo.py
--- /tmp/foo.py (original)
+++ /tmp/foo.py (refactored)
@@ -1 +1 @@
-import dummy_thread
+import _dummy_thread
RefactoringTool: Files that need to be modified:
RefactoringTool: /tmp/foo.py
Yep, I kept them on purpose. At least, it helps to make code compatible with Python 3.7. |
Remove _dummy_thread and dummy_threading modules. These modules were deprecated since Python 3.7 which requires threading support.
|
PR rebased to handle a conflict. |
methane
approved these changes
Jun 17, 2019
|
Thanks for the review @methane. Tests pass, I merged my PR. |
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
…-14143) Remove _dummy_thread and dummy_threading modules. These modules were deprecated since Python 3.7 which requires threading support.
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
…-14143) Remove _dummy_thread and dummy_threading modules. These modules were deprecated since Python 3.7 which requires threading support.
arhadthedev
added a commit
to nirs/cpython
that referenced
this pull request
May 22, 2023
I hope it will unblock the GitHub built-in merge resolver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove _dummy_thread and dummy_threading modules. These modules
were deprecated since Python 3.7 which requires threading support.
https://bugs.python.org/issue37312