bpo-37285: setup.py: avoid joining the SDKROOT twice #14095
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
mistydemeo
force-pushed
the
setup_py_double_sdkroot
branch
from
750cb37
to
bd9e01e
Compare
| """ | ||
| Returns True if 'path' can be located in an OSX SDK | ||
| """ | ||
| return ( (path.startswith('/usr/') and not path.startswith('/usr/local')) | ||
| or path.startswith('/System/') | ||
| or path.startswith('/Library/') ) | ||
| or (path.startswith('/Library/') and not path.startswith(sysroot)) ) |
There was a problem hiding this comment.
It is not immediately clear why "and not ..." is necessary. Please add a comment that explains this.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Fixes https://bugs.python.org/issue37285.
https://bugs.python.org/issue37285