bpo-28556: Routine updates to typing #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ilevkivskyi, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zware, @serhiy-storchaka and @rhettinger to be potential reviewers. |
|
Maybe update Misc/NEWS too? |
Thank you @Mariatta, good point! Fixed this. |
|
And of course there is a conflict now :( |
Resolved. |
Mariatta
approved these changes
May 2, 2017
|
Thanks :) I'll merge after the build is finished. |
Mariatta
pushed a commit
to Mariatta/cpython
that referenced
this pull request
May 3, 2017
- Add NoReturn type - Use WrapperDescriptorType (original PR by Jim Fasarakis-Hilliard) - Minor bug-fixes (cherry picked from commit f06e021)
Mariatta
pushed a commit
to Mariatta/cpython
that referenced
this pull request
May 3, 2017
- Add NoReturn type - Use WrapperDescriptorType (original PR by Jim Fasarakis-Hilliard) - Minor bug-fixes (cherry picked from commit f06e021)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typingmodule was last updated 2 months ago. Here are few more updates:NoReturntypeWrapperDescriptorType(original PR by Jim Fasarakis-Hilliard)This needs to be backported to 3.5 and 3.6
Attn: @gvanrossum