-
-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-36984: Improve version added references in typing
module docs
#13457
bpo-36984: Improve version added references in typing
module docs
#13457
Conversation
@@ -599,6 +599,7 @@ The module defines the following classes, functions and decorators: | |||
|
|||
A generic version of :class:`collections.deque`. | |||
|
|||
.. versionadded:: 3.5.4 | |||
.. versionadded:: 3.6.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there 2 "versionadded" here ? was this added both ein 3.5.4 and 3.6.1 ? Meaning it's not in 3.6.0 ?
If that's the case that might look like a typo in the docs from a casual reader, and might need a clarification paragraph.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's correct! it is pretty weird!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the story with versions is related to the fact that typing
module used to be provisional, so features were added at random time, even between minor releases.
@@ -708,12 +719,14 @@ The module defines the following classes, functions and decorators: | |||
|
|||
A generic version of :class:`collections.Counter`. | |||
|
|||
.. versionadded:: 3.5.4 | |||
.. versionadded:: 3.6.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same on all of these; that feel super weird;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version added are always super useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
@@ -599,6 +599,7 @@ The module defines the following classes, functions and decorators: | |||
|
|||
A generic version of :class:`collections.deque`. | |||
|
|||
.. versionadded:: 3.5.4 | |||
.. versionadded:: 3.6.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the story with versions is related to the fact that typing
module used to be provisional, so features were added at random time, even between minor releases.
Thanks @asottile for the PR, and @ilevkivskyi for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
) (cherry picked from commit b7daabd) Co-authored-by: Anthony Sottile <[email protected]>
GH-13737 is a backport of this pull request to the 3.7 branch. |
(cherry picked from commit b7daabd) Co-authored-by: Anthony Sottile <[email protected]>
https://bugs.python.org/issue36984