Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36922: implement Py_TPFLAGS_METHOD_DESCRIPTOR #13338

Merged
merged 6 commits into from
May 28, 2019
Merged

bpo-36922: implement Py_TPFLAGS_METHOD_DESCRIPTOR #13338

merged 6 commits into from
May 28, 2019

Conversation

jdemeyer
Copy link
Contributor

@jdemeyer jdemeyer commented May 15, 2019 •
edited by bedevere-bot
Loading

@jdemeyer jdemeyer requested a review from rhettinger as a code owner May 15, 2019 11:12
@jdemeyer jdemeyer force-pushed the Py_TPFLAGS_METHOD_DESCRIPTOR branch from ecdd21d to 5e315bb Compare May 15, 2019 11:12
@jdemeyer
Copy link
Contributor Author

Petr: do you think this should be _Py_TPFLAGS_METHOD_DESCRIPTOR (with underscore) or is this useful enough to make public right away?

This PR is otherwise independent from the rest of PEP 590, so it's possible to make it public.

@encukou
Copy link
Member

encukou commented May 17, 2019

I don't see this one changing, so I'm OK with making this public.

encukou
encukou reviewed May 21, 2019
View reviewed changes
Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you! It should go in after PEP is accepted.

@jdemeyer jdemeyer force-pushed the Py_TPFLAGS_METHOD_DESCRIPTOR branch from 5e315bb to 39f3498 Compare May 21, 2019 12:06
@jdemeyer jdemeyer mentioned this pull request May 22, 2019
Merged
@jdemeyer jdemeyer force-pushed the Py_TPFLAGS_METHOD_DESCRIPTOR branch from 39f3498 to 1f65f80 Compare May 22, 2019 14:59
@jdemeyer
Copy link
Contributor Author

Rebased to latest master (no other changes).

@encukou encukou merged commit eb65e24 into python:master May 28, 2019
@jdemeyer jdemeyer deleted the Py_TPFLAGS_METHOD_DESCRIPTOR branch June 26, 2019 08:22
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@jdemeyer @markshannon @DinoV
bpo-36922: implement PEP-590 Py_TPFLAGS_METHOD_DESCRIPTOR (pythonGH-1…
e82ab9d 
…3338)

Co-authored-by: Mark Shannon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encukou encukou encukou left review comments

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jdemeyer @encukou @the-knights-who-say-ni @bedevere-bot @markshannon