bpo-28269: Replace strcasecmp with system function stricmp #13095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Microsoft deprecated |
|
Just tried, MinGW also accept _stricmp. I'll use it instead. Thanks @serhiy-storchaka . |
BoboTiG
reviewed
May 28, 2019
There was a problem hiding this comment.
LGTM, thank you @gongminmin :)
@skrah, do you think it is worth deleting those lines too?
cpython/Modules/_decimal/libmpdec/vccompat.h
Lines 46 to 47 in 3880f26
And also update this comment to remove any occurrences of strcasecmp?
cpython/Modules/_decimal/libmpdec/io.c
Line 55 in 74d7f76
Misc/NEWS.d/next/Windows/2019-05-05-05-23-34.bpo-28269.-MOHI7.rst
Outdated
Show resolved
Hide resolved
Co-Authored-By: Mickaël Schoentgen <[email protected]>
No, |
BoboTiG
approved these changes
May 28, 2019
|
Ping? |
serhiy-storchaka
approved these changes
Jul 10, 2019
serhiy-storchaka
added
needs backport to 2.7
needs backport to 3.8
|
Thanks @gongminmin for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.7, 3.8. |
|
GH-14740 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 13, 2019
…H-13095) (cherry picked from commit 05f2d84) Co-authored-by: Minmin Gong <[email protected]>
|
GH-14741 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 13, 2019
…H-13095) (cherry picked from commit 05f2d84) Co-authored-by: Minmin Gong <[email protected]>
|
Sorry, @gongminmin and @serhiy-storchaka, I could not cleanly backport this to |
miss-islington
added a commit
that referenced
this pull request
Aug 24, 2019
(cherry picked from commit 05f2d84) Co-authored-by: Minmin Gong <[email protected]>
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
jcfr
added a commit
to python-cmake-buildsystem/cpython
that referenced
this pull request
Jan 18, 2022
This commit integrates changes originally added to the project as python-cmake-buildsystem/python-cmake-buildsystem@18d49757e (Mingw32 support, and add cmake options for disabling) Note that in more recent version of Python, this patch is obsoleted by the following commits: See python/cpython@589f89e2a (introduced in 3.3) Removed a Windows 9x trick used before LoadLibraryExW. Windows 9x has long been unsupported and the result of GetFullPathName was not even being used in the first place. See python/cpython@05f2d84ca (introduced in 3.9) bpo-28269: Replace strcasecmp with system function _stricmp. (pythonGH-13095) Co-authored-by: David Sansome <[email protected]>
jcfr
added a commit
to python-cmake-buildsystem/cpython
that referenced
this pull request
Jan 18, 2022
This commit integrates changes originally added to the project as python-cmake-buildsystem/python-cmake-buildsystem@18d49757e (Mingw32 support, and add cmake options for disabling) Note that in more recent version of Python, this patch is obsoleted by the following commits: See python/cpython@589f89e2a (introduced in 3.3) Removed a Windows 9x trick used before LoadLibraryExW. Windows 9x has long been unsupported and the result of GetFullPathName was not even being used in the first place. See python/cpython@05f2d84ca (introduced in 3.9) bpo-28269: Replace strcasecmp with system function _stricmp. (pythonGH-13095) Co-authored-by: David Sansome <[email protected]>
jcfr
added a commit
to python-cmake-buildsystem/cpython
that referenced
this pull request
Jan 18, 2022
This commit integrates changes originally added to the project as python-cmake-buildsystem/python-cmake-buildsystem@18d49757e (Mingw32 support, and add cmake options for disabling) Note that in more recent version of Python, this patch is obsoleted by the following commits: See python/cpython@589f89e2a (introduced in 3.3) Removed a Windows 9x trick used before LoadLibraryExW. Windows 9x has long been unsupported and the result of GetFullPathName was not even being used in the first place. See python/cpython@05f2d84ca (introduced in 3.9) bpo-28269: Replace strcasecmp with system function _stricmp. (pythonGH-13095) Co-authored-by: David Sansome <[email protected]>
jcfr
added a commit
to python-cmake-buildsystem/cpython
that referenced
this pull request
Jan 18, 2022
This commit integrates changes originally added to the project as python-cmake-buildsystem/python-cmake-buildsystem@18d49757e (Mingw32 support, and add cmake options for disabling) Note that in more recent version of Python, this patch is obsoleted by the following commits: See python/cpython@589f89e2a (introduced in 3.3) Removed a Windows 9x trick used before LoadLibraryExW. Windows 9x has long been unsupported and the result of GetFullPathName was not even being used in the first place. See python/cpython@05f2d84ca (introduced in 3.9) bpo-28269: Replace strcasecmp with system function _stricmp. (pythonGH-13095) Co-authored-by: David Sansome <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is from a comment in the issue. Replace strcasecmp in Python/dynload_win.c to posix stricmp,
https://bugs.python.org/issue28269