bpo-2091: Fix typo in exception message #12987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tirkarthi
approved these changes
Apr 27, 2019
There was a problem hiding this comment.
LGTM. I am not sure of backporting this to 3.7. There was a similar typo fixed in Lib/random.py error message and was not backported to 3.7 as noted in https://bugs.python.org/issue35782#msg334364.
Thanks.
|
We don't backport changes to existing error messages only when we significantly changed their formats. 2433a2a and this one are completely OK to backport. |
|
Thanks @berkerpeksag for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 27, 2019
(cherry picked from commit 21a9ba1) Co-authored-by: Berker Peksag <[email protected]>
|
GH-12988 is a backport of this pull request to the 3.7 branch. |
berkerpeksag
added a commit
that referenced
this pull request
Apr 27, 2019
(cherry picked from commit 21a9ba1) Co-authored-by: Berker Peksag <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue2091