gh-122392: Fix the wrong size of the Path Browser vertical spacing for IDLE (#122392)

[Xiaokang2022]

The Path Browser vertical interval size was originally set to 20, but this caused display issues (such as overlapping) on some devices. Actually, we should calculate the size, and giving a fixed value will not solve the problem in all cases.

But no matter what the value is, the elements in the first row will not use it, so we can get the size of this value through the elements in the first row after the first row is drawn, and assign the value to the corresponding variable for the subsequent elements to use.

After testing, this solution worked very well on my device (Windows10 22H2 1920x1080).

• Issue: IDLE: Path Browser vertical spacing is too small, causing the text to be cut off #122392

[cpython-cla-bot]

All commit authors signed the Contributor License Agreement.

[bedevere-app]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

[terryjreedy]

See additional new comment on issue.

[bedevere-app]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[Xiaokang2022]

I have made the requested changes; please review again.

[bedevere-app]

Thanks for making the requested changes!

@terryjreedy: please review the changes made to this pull request.

[terryjreedy]

@serhiy-storchaka, @ned-deily, @ronaldoussoren: I am pretty sure that this should work on linux/macOS, but would any of you like to test before I merge? Open IDLE, select File => pathbrowser, open /Lib, the underscores and descenders on pyg should be complete (they likely would not have been before if you have a high-def screen). If normal screen, the space between folder icons should be about the same size as the icons.

[Xiaokang2022]

I tested it on Arch Linux and it looks like this:

[Xiaokang2022]

Hello, @terryjreedy

Regarding your second comment from the above review, I think there may be something wrong with some. Tonight, after I looked through the source code in the past, I found that the reason for the value of 17 here may be caused by you missing it in a change from 10 years ago. (9a6f8e1)

So I think my previous code might be correct. Of course, there may be some problems that I have not taken into account, and if so, please forgive me and point them out.

[terryjreedy]

Good digging. I could think that if 17 has not resulted in a report, maybe it was OK. But people mostly do not report glitches. Better safe than sorry.

[terryjreedy]

I intend to merge this after 3.13.0 is released, which is scheduled to be within a day.

[miss-islington-app]

Thanks @Xiaokang2022 for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

[bedevere-app]

GH-125061 is a backport of this pull request to the 3.13 branch.

[bedevere-app]

GH-125062 is a backport of this pull request to the 3.12 branch.