Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-103484: Fix permanently redirects reported by linkcheck #124144

Merged

Conversation

rffontenelle
Copy link
Contributor

@rffontenelle rffontenelle commented Sep 16, 2024

This is another patch required to fix the current state of make linkcheck in Python Docs. This pull request fixes occurrences of "redirected permanently" as reported by make linkcheck.

Please backport to 3.13 and 3.12 branches.

See below the linkcheck occurrences this PR handles:

Add or remove 'www'

http to https

URL path change

Domain name change

www.openssl.org/docs to docs.openssl.org

pypi.org package URL normalization

Expanding discuss.python.org URL

Website unavailable (remove or use wayback machine)

Changes done by the bots (separated for avoid confusion)


📚 Documentation preview 📚: https://cpython-previews--124144.org.readthedocs.build/

Copy link
Member

@gpshead gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all new URLs validated vs old for redirects.

Doc/library/os.rst Outdated Show resolved Hide resolved
@gpshead gpshead added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes docs Documentation in the Doc dir labels Sep 16, 2024
@gpshead gpshead self-assigned this Sep 16, 2024
@gpshead gpshead enabled auto-merge (squash) September 16, 2024 22:34
auto-merge was automatically disabled September 17, 2024 00:56

Head branch was pushed to by a user without write access

@rffontenelle
Copy link
Contributor Author

rffontenelle commented Sep 17, 2024

Added a ignore rule for discuss.python.org URL and undid the change in library/os.rst, to avoid this and future redirects caused by title text change.

@gpshead gpshead enabled auto-merge (squash) September 17, 2024 02:11
@gpshead gpshead merged commit 0a32c69 into python:main Sep 17, 2024
23 checks passed
@miss-islington-app
Copy link

Thanks @rffontenelle for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 17, 2024
…honGH-124144)

Fix redirects reported by linkcheck, update docs conf.py checks.
(cherry picked from commit 0a32c69)

Co-authored-by: Rafael Fontenelle <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 17, 2024

GH-124151 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 17, 2024
…honGH-124144)

Fix redirects reported by linkcheck, update docs conf.py checks.
(cherry picked from commit 0a32c69)

Co-authored-by: Rafael Fontenelle <[email protected]>
@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 17, 2024
@bedevere-app
Copy link

bedevere-app bot commented Sep 17, 2024

GH-124152 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Sep 17, 2024
gpshead pushed a commit that referenced this pull request Sep 17, 2024
…-124144) (GH-124152)

Fix redirects reported by linkcheck, update docs conf.py checks.
(cherry picked from commit 0a32c69)

Co-authored-by: Rafael Fontenelle <[email protected]>
@rffontenelle rffontenelle deleted the rffontenelle-fix-permanently-redirects branch September 17, 2024 07:17
savannahostrowski pushed a commit to savannahostrowski/cpython that referenced this pull request Sep 22, 2024
…honGH-124144)

Fix redirects reported by linkcheck, update docs conf.py checks.
Yhg1s pushed a commit that referenced this pull request Sep 24, 2024
…-124144) (#124151)

GH-103484: Fix permanently redirects reported by linkcheck (GH-124144)

Fix redirects reported by linkcheck, update docs conf.py checks.
(cherry picked from commit 0a32c69)

Co-authored-by: Rafael Fontenelle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants