bpo-36333: Fix leak in _PyRuntimeState_Fini #12400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
approved these changes
Mar 18, 2019
There was a problem hiding this comment.
LGTM, but I would prefer that @ericsnowcurrently review it since he added _PyRuntime.xidregistry (and its mutex).
|
Python 3.7 is not affected: it doesn't have _PyRuntime.xidregistry. |
ericsnowcurrently
approved these changes
Mar 18, 2019
|
FWIW, |
@matrixise: Can you try to free _PyRuntime.ceval.pending.lock in _PyEval_FiniThreads()? |
|
@ericsnowcurrently I will check in an other PR. Thanks for the review |
|
Ok i will do it |
|
I merged this PR, thanks @matrixise. Oh, there are now too many leaks... I merged https://bugs.python.org/issue36356 PR and I wrote PR #12432 to free the pending lock, to have a better view of remaining leaks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue36333