chore: decimal module macro cleanup #123791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the usages of the `UNUSED` macro which was not consistent with the `Py_UNUSED` macro itself. In addition, this amends the parameter names so that they match their semantic meanings.
|
cc @vstinner since you were the one reviewing my |
Note: I prefer to not review draft PRs in general. |
Oh sorry for that. I'll keep in mind in the future! |
|
In general, I dislike PRs which only change coding style, but reusing the Py_UNUSED() macro is a good thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I looked at the refleaks in the decimal module, I observed that some macros are not protected against dangling else and that
UNUSEDdoes not matchPy_UNUSED.I didn't want to make two different PRs (though I can cherry-pick the commits since they are easy separated); nevertheless, I think the
do-whileprotection should be included (I've already done this kind of PRs in the past).There are some casts are redundant and one argument that was marked as unused but that was not! Some methods used 'args' but were using the
METH_NOARGS(so it could be confusing to users!) flag. There is one exception beingdec_copywhich both uses aMETH_NOARGSandMETH_Oflag for__copy__and__deepcopy__respectively. I left it asdummybut added a small comment.