gh-107954, PEP 741: Add PyConfig_Get() function #123472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add PyConfig_Get(), PyConfig_GetInt(), PyConfig_Set() and PyConfig_Names() functions to get and set the current runtime Python configuration. _PyConfig_AsDict() now converts PyConfig.xoptions as a dictionary.
vstinner
requested review from
a team,
ericsnowcurrently and
erlend-aasland
as code owners
|
(Previous version of the PR, before PEP 741 was accepted: #112609.) |
|
cc @zooba |
picnixz
reviewed
Aug 30, 2024
Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
|
@picnixz: About your suggested changes to replace |
|
@picnixz: I addressed most of your reviews. |
Sound good to me. Consistency in this case is better so I'm fine. And PEP 7 indeed doesn't say anything on this matter (it just says that the function name must be on its own line I think).
Thank you! |
Update also PyConfig in _PySys_SetIntMaxStrDigits().
Add _PyWideStringList_AsTuple() function.
|
|
|
@vstinner Seems this PR broke the Linux perf profiler buildbots (and have been broken since) |
|
@pablogsal do you have some details? |
|
No other than the buildbot logs |
|
I can try to look into this once I am back from the core dev sprint since here I don't have a laptop with new enough perf |
|
I can confirm that the previous commit builds correctly |
|
Found the problem: #124636 |
|
Yes, it fixes the issue I raised Thanks! |
|
But also the real question is: why wasn't this picked up by the GH runners and rely on buildbot builds? |
Because running the minimum Perf in GH runners is close to impossible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PyConfig_Get(), PyConfig_GetInt(), PyConfig_Set() and PyConfig_Names() functions to get and set the current runtime Python configuration.
_PyConfig_AsDict() now converts PyConfig.xoptions as a dictionary.
📚 Documentation preview 📚: https://cpython-previews--123472.org.readthedocs.build/