Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-123363: Show string value of CONTAINS_OP oparg in dis #123387

Merged
merged 8 commits into from
Aug 28, 2024

Conversation

Alexandr153
Copy link
Contributor

@Alexandr153 Alexandr153 commented Aug 27, 2024

Result:

>>> echo 'a not in  b' | ./python.exe -m dis
  0           RESUME                   0

  1           LOAD_NAME                0 (a)
              LOAD_NAME                1 (b)
              CONTAINS_OP              1 (not in)
              RETURN_VALUE
>>> echo 'a in  b' | ./python.exe -m dis
  0           RESUME                   0

  1           LOAD_NAME                0 (a)
              LOAD_NAME                1 (b)
              CONTAINS_OP              0 (in)
              RETURN_VALUE

Copy link

cpython-cla-bot bot commented Aug 27, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Aug 27, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@Alexandr153 Alexandr153 changed the title Show string value of CONTAINS_OP oparg in dis gh-123363: Show string value of CONTAINS_OP oparg in dis Aug 27, 2024
@bedevere-app
Copy link

bedevere-app bot commented Aug 27, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@Eclips4 Eclips4 requested a review from sobolevn August 28, 2024 05:37
Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sobolevn sobolevn merged commit 6a7765b into python:main Aug 28, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants