-
-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-123189: [Modules/blake2module.c
]: Move function definitions and their usage under the macros
#123190
Conversation
cc @msprotz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a more python-idiomatic way of doing this? I remember seeing something like Py_Unused that might have helped with these warnings.
|
ok, worst case, you could do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this fix:
» make
gcc -I./Modules/_hacl/include -fno-strict-overflow -Wsign-compare -g -Og -Wall -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include -fstack-protector-strong -std=c11 -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wstrict-prototypes -Werror=implicit-function-declaration -fvisibility=hidden -I./Include/internal -I./Include/internal/mimalloc -I. -I./Include -I/opt/homebrew/opt/openssl/include -I/opt/homebrew/opt/openssl/include -c ./Modules/blake2module.c -o Modules/blake2module.o
gcc -bundle -undefined dynamic_lookup -L/opt/homebrew/opt/openssl/lib -L/opt/homebrew/opt/openssl/lib Modules/blake2module.o Modules/_hacl/libHacl_Hash_Blake2.a -o Modules/_blake2.cpython-314d-darwin.so
The necessary bits to build these optional modules were not found:
_gdbm _tkinter
To find the necessary bits, look in configure.ac and config.log.
Checked 112 modules (34 built-in, 76 shared, 0 n/a on macosx-14.5-arm64, 0 disabled, 2 missing, 0 failed on import)
Thank you!
./Modules/blake2module.c:314:18: warning: unused variable 'st' [-Wunused-variable]
#123189