Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-118943: Remove 'regen-jit' from the 'regen-all' make target #122602

Merged
merged 6 commits into from
Aug 8, 2024
Merged

gh-118943: Remove 'regen-jit' from the 'regen-all' make target #122602

merged 6 commits into from
Aug 8, 2024

Conversation

hroncok
Copy link
Contributor

@hroncok hroncok commented Aug 2, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Aug 2, 2024
Closed
@hroncok hroncok mentioned this pull request Aug 2, 2024
Merged
@Eclips4 Eclips4 added the needs backport to 3.13 bugs and security fixes label Aug 2, 2024
@erlend-aasland
Copy link
Contributor

Workflow nit: instead of opening a PR against a closed issue, please either re-open the existing issue, or create a new one.

@erlend-aasland
Copy link
Contributor

For the record, see #120690 (review) for why this PR was made.

erlend-aasland
erlend-aasland requested changes Aug 2, 2024
View reviewed changes
.github/workflows/build.yml Outdated Show resolved Hide resolved
@bedevere-app
Copy link

bedevere-app bot commented Aug 2, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

merwok
merwok reviewed Aug 2, 2024
View reviewed changes
Makefile.pre.in Outdated Show resolved Hide resolved
@hroncok
Copy link
Contributor Author

hroncok commented Aug 3, 2024

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented Aug 3, 2024

Thanks for making the requested changes!

@erlend-aasland: please review the changes made to this pull request.

@hroncok
Copy link
Contributor Author

hroncok commented Aug 5, 2024

The aarch64 CI failures seem unrelated to this PR.

brandtbucher
brandtbucher requested changes Aug 5, 2024
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we literally just need to remove regen-jit from regen-all, nothing more. :)

.github/workflows/jit.yml Outdated Show resolved Hide resolved
Makefile.pre.in Outdated Show resolved Hide resolved
Misc/NEWS.d/next/Build/2024-08-02-12-59-15.gh-issue-118943.vZQtET.rst Outdated Show resolved Hide resolved
@bedevere-app
Copy link

bedevere-app bot commented Aug 5, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@brandtbucher brandtbucher self-assigned this Aug 5, 2024
@brandtbucher brandtbucher added build The build process and cross-build topic-JIT labels Aug 5, 2024
brandtbucher
brandtbucher approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hroncok
Copy link
Contributor Author

hroncok commented Aug 5, 2024

I misunderstood the problem at first. I assumed calling make regen-jit was still necessary.

However, I now see that the jit_stencils.h target calls the same command, which probably explains why it was called parallelly.

@brandtbucher brandtbucher merged commit 8c9d174 into python:main Aug 8, 2024
34 of 36 checks passed
@miss-islington-app
Copy link

Thanks @hroncok for the PR, and @brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 8, 2024
@hroncok @merwok @miss-islington
pythonGH-118943: Remove regen-jit from the regen-all make target (pyt…
0d5ed2e 
…honGH-122602)

(cherry picked from commit 8c9d174)

Co-authored-by: Miro Hrončok <[email protected]>
Co-authored-by: Éric <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Aug 8, 2024

GH-122840 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Aug 8, 2024
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@hroncok @merwok @blhsing
pythonGH-118943: Remove regen-jit from the regen-all make target (pyt…
701a1d7 
…honGH-122602)

Co-authored-by: Éric <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merwok merwok merwok left review comments

@brandtbucher brandtbucher brandtbucher approved these changes

@Eclips4 Eclips4 Eclips4 approved these changes

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti

@hugovk hugovk Awaiting requested review from hugovk

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Assignees

@brandtbucher brandtbucher

Labels
build The build process and cross-build topic-JIT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hroncok @erlend-aasland @merwok @brandtbucher @Eclips4