bpo-29191: Add liblzma.vcxproj to pcbuild.sln and other missing entries #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liblzma is missing from pcbuild.sln. This causes the build of _lzma to fail when building the solution and not using build.bat.
|
@segevfiner, thanks for your PR! By analyzing the history of the files in this pull request, we identified @briancurtin, @zooba and @amauryfa to be potential reviewers. |
zooba
approved these changes
Apr 20, 2017
zooba
pushed a commit
to zooba/cpython
that referenced
this pull request
Apr 21, 2017
…es (python#1222) liblzma is missing from pcbuild.sln. This causes the build of _lzma to fail when building the solution and not using build.bat.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
liblzma is missing from pcbuild.sln. This causes the build of _lzma to fail when building the solution and not using build.bat.
A similar patch is simple enough to create for older versions/branches, in case this doesn't back port cleanly. Just Add->Existing Project liblzma.vcxproj and make sure to revert any lines in the sln which Visual Studio added that you don't want to commit (Like VisualStudioVersion = ...).