gh-100240: Use a consistent implementation for freelists #121934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This combines and updates our freelist handling to use a consistent implementation. Objects in the freelist are linked together using the first word of memory block. If configured with freelists disabled, these operations are essentially no-ops.
colesbury
requested review from
ericsnowcurrently,
corona10,
markshannon and
Fidget-Spinner
|
I'm putting this up for discussion and feedback. @markshannon, this doesn't do all the things listed in the issue -- I haven't In my limited testing, I haven't seen a significant performance difference. |
|
Perfomance is in the noise but doesn't look like it's any worse. |
markshannon
approved these changes
Jul 18, 2024
corona10
approved these changes
Jul 18, 2024
Co-authored-by: Mark Shannon <[email protected]>
|
!buildbot AMD64 Ubuntu NoGIL Refleaks |
|
🤖 New build scheduled with the buildbot fleet by @colesbury for commit aa8e4d5 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This combines and updates our freelist handling to use a consistent implementation. Objects in the freelist are linked together using the first word of memory block.
When Python is configured to build without freelists, these operations are essentially no-ops.