Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-36179: Fix ref leaks in _hashopenssl #12158

Merged
merged 1 commit into from
Mar 4, 2019

Conversation

tiran
Copy link
Member

@tiran tiran commented Mar 4, 2019

Fix two unlikely reference leaks in _hashopenssl. The leaks only occur in
out-of-memory cases. Thanks to Charalampos Stratakis.

Signed-off-by: Christian Heimes [email protected]

https://bugs.python.org/issue36179

Fix two unlikely reference leaks in _hashopenssl. The leaks only occur in
out-of-memory cases. Thanks to Charalampos Stratakis.

Signed-off-by: Christian Heimes <[email protected]>
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@miss-islington
Copy link
Contributor

@tiran: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit b7bc283 into python:master Mar 4, 2019
@miss-islington
Copy link
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 4, 2019
Fix two unlikely reference leaks in _hashopenssl. The leaks only occur in
out-of-memory cases. Thanks to Charalampos Stratakis.

Signed-off-by: Christian Heimes <[email protected]>

https://bugs.python.org/issue36179
(cherry picked from commit b7bc283)

Co-authored-by: Christian Heimes <[email protected]>
@bedevere-bot
Copy link

GH-12164 is a backport of this pull request to the 3.7 branch.

@miss-islington
Copy link
Contributor

Sorry, @tiran, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b7bc283ab6a23ee98784400ebffe7fe410232a2e 3.6

@miss-islington miss-islington self-assigned this Mar 4, 2019
@miss-islington
Copy link
Contributor

Sorry, @tiran, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b7bc283ab6a23ee98784400ebffe7fe410232a2e 2.7

tiran added a commit to tiran/cpython that referenced this pull request Mar 4, 2019
Fix two unlikely reference leaks in _hashopenssl. The leaks only occur in
out-of-memory cases. Thanks to Charalampos Stratakis.

Signed-off-by: Christian Heimes <[email protected]>

https://bugs.python.org/issue36179.
(cherry picked from commit b7bc283)

Co-authored-by: Christian Heimes <[email protected]>
@bedevere-bot
Copy link

GH-12165 is a backport of this pull request to the 3.6 branch.

@tiran tiran deleted the bpo36179-hashopenssl-ref branch March 4, 2019 16:00
tiran added a commit to tiran/cpython that referenced this pull request Mar 4, 2019
Fix two unlikely reference leaks in _hashopenssl. The leaks only occur in
out-of-memory cases. Thanks to Charalampos Stratakis.

Signed-off-by: Christian Heimes <[email protected]>

https://bugs.python.org/issue36179.
(cherry picked from commit b7bc283)

Co-authored-by: Christian Heimes <[email protected]>
@bedevere-bot
Copy link

GH-12166 is a backport of this pull request to the 2.7 branch.

miss-islington added a commit that referenced this pull request Mar 4, 2019
Fix two unlikely reference leaks in _hashopenssl. The leaks only occur in
out-of-memory cases. Thanks to Charalampos Stratakis.

Signed-off-by: Christian Heimes <[email protected]>

https://bugs.python.org/issue36179
(cherry picked from commit b7bc283)

Co-authored-by: Christian Heimes <[email protected]>
miss-islington pushed a commit that referenced this pull request Mar 4, 2019
Fix two unlikely reference leaks in _hashopenssl. The leaks only occur in
out-of-memory cases. Thanks to Charalampos Stratakis.

Signed-off-by: Christian Heimes <[email protected]>

https://bugs.python.org/issue36179.
(cherry picked from commit b7bc283)

Co-authored-by: Christian Heimes <[email protected]>



https://bugs.python.org/issue36179
Copy link
Member

@gpshead gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants