gh-121025: improve partialmethod.__repr__
#121033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnixz
requested review from
1st1,
asvetlov,
gvanrossum,
kumaraditya303 and
willingc
as code owners
|
I’m sorry, I am on vacation and dealing with health issues, and unavailable for review. |
|
(I'm also very sorry that you got requested for a single change in a regex) |
serhiy-storchaka
added
needs backport to 3.12
|
Thanks @picnixz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Thanks @picnixz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 26, 2024
It no longer contains redundant commas and spaces. (cherry picked from commit d2646e3) Co-authored-by: Bénédikt Tran <[email protected]>
|
GH-121037 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 26, 2024
It no longer contains redundant commas and spaces. (cherry picked from commit d2646e3) Co-authored-by: Bénédikt Tran <[email protected]>
|
GH-121038 is a backport of this pull request to the 3.12 branch. |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Jun 26, 2024
It no longer contains redundant commas and spaces. (cherry picked from commit d2646e3) Co-authored-by: Bénédikt Tran <[email protected]>
kumaraditya303
pushed a commit
that referenced
this pull request
Jun 26, 2024
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
It no longer contains redundant commas and spaces.
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
It no longer contains redundant commas and spaces.
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
It no longer contains redundant commas and spaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI,
partial.__repr__is marked withrecursive_repr(), but not partialmethod. For now, I did not mark it but if you think it should, I can add it.