gh-120678: pyrepl: Include globals from modules passed with `-i` #120904

AlexWaygood · 2024-06-23T12:42:23Z

In order to fix the regression caused by #119547, this PR goes back to the original fix that was proposed in the early commits of #119547.

The REPL must use the globals from sys.modules["__main__"] in case a different module has been run as __main__ using -i; in order to prevent globals from _pyrepl.__main__ from leaking into the global namespace, we move the vast majority of the globals out of __main__.py instead of running the REPL with an entirely fresh set of globals.

Some small filtering of globals is additionally done in Lib/_pyrepl/simple_interact.py, so that we're able to import functions and classes in _pyrepl.__main__ without these globals leaking into the REPL environment. (This filtering only works for things with __module__ attributes, though, so it's still best to keep _pyrepl/__main__.py as minimal as possible.)

This still doesn't exactly match the behaviour of the old REPL for some dunders:

~/dev/cpython (repl-globals)⚡ % cat foo.py           
"""For fooey things"""
FOO: int = 42
~/dev/cpython (repl-globals)⚡ % PYTHON_BASIC_REPL=1 ./python.exe -i foo.py
>>> __doc__
'For fooey things'
>>> exit()
~/dev/cpython (repl-globals)⚡ % ./python.exe -i foo.py                    
>>> __doc__
>>>

I'm not really sure why that is!

Issue: New REPL does not include globals from executed module when used with -i #120678

AlexWaygood · 2024-06-23T12:43:52Z

Cc. @eryksun if you're interested!

eryksun

Thank you. LGTM 🚀

ambv · 2024-06-26T19:03:53Z

Sorry, didn't notice this was the same as gh-121054 as I looked at the root cause, which was gh-118908.

Let's keep this for additional test you added, and the __main__ comment to not add things there.

ambv · 2024-06-26T19:43:59Z

The reason why __cached__, __file__, __package__, __spec__, and __doc__ are wrong is that PyREPL is also a package now, and it's started after the fact in the same namespace. So it effectively overwrites those attributes from what was previously set:

>>> __package__
'_pyrepl'
>>> __name__
'__main__'
>>> __spec__
ModuleSpec(name='_pyrepl.__main__', loader=<_frozen_importlib_external.SourceFileLoader object at 0x103a020c0>, origin='/Volumes/RAMDisk/cpython/Lib/_pyrepl/__main__.py')
>>> __file__
'/Volumes/RAMDisk/cpython/Lib/_pyrepl/__main__.py'

We'd need to work around that.

ambv · 2024-07-17T13:11:24Z

Lib/test/test_pyrepl/test_pyrepl.py

@@ -487,6 +489,18 @@ def prepare_reader(self, events):
        reader.can_colorize = False
        return reader

+    def test_stdin_is_tty(self):


This was helpful to me when debugging weird behavior so I decided to keep it.

Lib/test/test_pyrepl/test_pyrepl.py

ambv · 2024-07-17T13:15:32Z

Modules/main.c

@@ -549,7 +597,7 @@ pymain_repl(PyConfig *config, int *exitcode)
        *exitcode = (run != 0);
        return;
    }
-    int run = pymain_run_module(L"_pyrepl", 0);
+    int run = pymain_start_pyrepl_no_main();


My first intuition was to simply PyImport_ImportModule("_pyrepl.__main__") but then the entire shell session is a side-effect of an on-going import, which was ugly and caused some funny edge cases (a non-zero exit was technically an ImportError).

So instead we do the full dance of running _pyrepl.main.interactive_console(). While doing that I'm smuggling PYTHONSTARTUP support because:

you can always remove PYTHONSTARTUP from your environment to not have it;

but previously you could not get PYTHONSTARTUP to be executed even if you wanted.

Lib/test/test_pyrepl/test_pyrepl.py

Modules/main.c

AlexWaygood · 2024-07-17T13:20:25Z

Thanks for picking this up @ambv!

ambv · 2024-07-17T13:21:09Z

It's team work: I push the shoddy changes, you get the git blame!

Lib/test/test_pyrepl/test_pyrepl.py

AlexWaygood

I can't give an approving review (since this is strictly speaking still "my PR" 😄), but from what I can tell this all LGTM! (With the caveat that I'm far from the world's greatest C programmer, so I could easily have missed something)

miss-islington-app · 2024-07-17T14:18:46Z

Thanks @AlexWaygood for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

pythonGH-120904) (cherry picked from commit ac07451) Co-authored-by: Alex Waygood <[email protected]> Co-authored-by: Łukasz Langa <[email protected]>

bedevere-app · 2024-07-17T14:18:59Z

GH-121916 is a backport of this pull request to the 3.13 branch.

bedevere-bot · 2024-07-17T14:35:36Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Ubuntu NoGIL 3.x has failed when building commit ac07451.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/1225/builds/2684) and take a look at the build logs.
Check if the failure is related to this commit (ac07451) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/1225/builds/2684

Failed tests:

test_pyrepl

Failed subtests:

test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/test_pyrepl/test_pyrepl.py", line 500, in test_stdout_is_tty
    if os.isatty(sys.stdout.fileno()):
                 ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno

bedevere-bot · 2024-07-17T14:36:15Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM Raspbian 3.x has failed when building commit ac07451.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/424/builds/7678) and take a look at the build logs.
Check if the failure is related to this commit (ac07451) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/424/builds/7678

Failed tests:

test_pyrepl

Failed subtests:

test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_pyrepl/test_pyrepl.py", line 500, in test_stdout_is_tty
    if os.isatty(sys.stdout.fileno()):
                 ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno

bedevere-bot · 2024-07-17T14:36:25Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x SLES 3.x has failed when building commit ac07451.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/540/builds/9493) and take a look at the build logs.
Check if the failure is related to this commit (ac07451) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/540/builds/9493

Failed tests:

test_pyrepl

Failed subtests:

test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Lib/test/test_pyrepl/test_pyrepl.py", line 500, in test_stdout_is_tty
    if os.isatty(sys.stdout.fileno()):
                 ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno

bedevere-bot · 2024-07-17T14:42:53Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Debian 3.x has failed when building commit ac07451.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/49/builds/9540) and take a look at the build logs.
Check if the failure is related to this commit (ac07451) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/49/builds/9540

Failed tests:

test_pyrepl

Failed subtests:

test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-debian-z/build/Lib/test/test_pyrepl/test_pyrepl.py", line 500, in test_stdout_is_tty
    if os.isatty(sys.stdout.fileno()):
                 ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno

…i` (GH-120904) (#121916) (cherry picked from commit ac07451) Co-authored-by: Alex Waygood <[email protected]> Co-authored-by: Łukasz Langa <[email protected]>

bedevere-bot · 2024-07-17T15:02:24Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Ubuntu NoGIL 3.13 has failed when building commit 3d9692d.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/1422/builds/284) and take a look at the build logs.
Check if the failure is related to this commit (3d9692d) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/1422/builds/284

Failed tests:

test_pyrepl

Failed subtests:

test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/test/test_pyrepl/test_pyrepl.py", line 500, in test_stdout_is_tty
    if os.isatty(sys.stdout.fileno()):
                 ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno

bedevere-bot · 2024-07-17T15:04:36Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x SLES 3.13 has failed when building commit 3d9692d.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/1437/builds/356) and take a look at the build logs.
Check if the failure is related to this commit (3d9692d) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/1437/builds/356

Failed tests:

test_pyrepl

Failed subtests:

test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.13.edelsohn-sles-z/build/Lib/test/test_pyrepl/test_pyrepl.py", line 500, in test_stdout_is_tty
    if os.isatty(sys.stdout.fileno()):
                 ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno

bedevere-bot · 2024-07-17T15:04:50Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM Raspbian 3.13 has failed when building commit 3d9692d.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/1435/builds/346) and take a look at the build logs.
Check if the failure is related to this commit (3d9692d) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/1435/builds/346

Failed tests:

test_pyrepl

Failed subtests:

test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/var/lib/buildbot/workers/3.13.gps-raspbian.nondebug/build/Lib/test/test_pyrepl/test_pyrepl.py", line 500, in test_stdout_is_tty
    if os.isatty(sys.stdout.fileno()):
                 ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno

bedevere-bot · 2024-07-17T15:05:59Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Debian 3.13 has failed when building commit 3d9692d.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/1485/builds/353) and take a look at the build logs.
Check if the failure is related to this commit (3d9692d) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/1485/builds/353

Failed tests:

test_pyrepl

Failed subtests:

test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.13.edelsohn-debian-z/build/Lib/test/test_pyrepl/test_pyrepl.py", line 500, in test_stdout_is_tty
    if os.isatty(sys.stdout.fileno()):
                 ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno

bedevere-bot · 2024-07-17T15:12:24Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86-64 MacOS Intel ASAN NoGIL 3.x has failed when building commit ac07451.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/1366/builds/1670) and take a look at the build logs.
Check if the failure is related to this commit (ac07451) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/1366/builds/1670

Failed tests:

test_pyrepl

Failed subtests:

test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-intel-aws.macos-with-brew.asan.nogil/build/Lib/test/test_pyrepl/test_pyrepl.py", line 500, in test_stdout_is_tty
    if os.isatty(sys.stdout.fileno()):
                 ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno

bedevere-bot · 2024-07-17T15:21:45Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86-64 MacOS Intel NoGIL 3.x has failed when building commit ac07451.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/1258/builds/2373) and take a look at the build logs.
Check if the failure is related to this commit (ac07451) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/1258/builds/2373

Failed tests:

test_pyrepl

Failed subtests:

test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-intel-aws.nogil/build/Lib/test/test_pyrepl/test_pyrepl.py", line 500, in test_stdout_is_tty
    if os.isatty(sys.stdout.fileno()):
                 ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno

bedevere-bot · 2024-07-17T15:25:44Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 MacOS M1 NoGIL 3.13 has failed when building commit 3d9692d.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/1408/builds/287) and take a look at the build logs.
Check if the failure is related to this commit (3d9692d) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/1408/builds/287

Failed tests:

test_pyrepl

Failed subtests:

test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/Users/ec2-user/buildbot/buildarea/3.13.itamaro-macos-arm64-aws.macos-with-brew.nogil/build/Lib/test/test_pyrepl/test_pyrepl.py", line 500, in test_stdout_is_tty
    if os.isatty(sys.stdout.fileno()):
                 ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno

bedevere-bot · 2024-07-17T15:27:03Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.13 has failed when building commit 3d9692d.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/1441/builds/318) and take a look at the build logs.
Check if the failure is related to this commit (3d9692d) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/1441/builds/318

Failed tests:

test_pyrepl

Failed subtests:

test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/root/buildarea/3.13.angelico-debian-amd64/build/Lib/test/test_pyrepl/test_pyrepl.py", line 500, in test_stdout_is_tty
    if os.isatty(sys.stdout.fileno()):
                 ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno

bedevere-bot · 2024-07-17T15:43:21Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Ubuntu Shared 3.x has failed when building commit ac07451.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/506/builds/8352) and take a look at the build logs.
Check if the failure is related to this commit (ac07451) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/506/builds/8352

Failed tests:

test_pyrepl

Failed subtests:

test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_pyrepl/test_pyrepl.py", line 500, in test_stdout_is_tty
    if os.isatty(sys.stdout.fileno()):
                 ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno

bedevere-bot · 2024-07-17T15:44:37Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86-64 MacOS Intel ASAN NoGIL 3.13 has failed when building commit 3d9692d.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/1460/builds/322) and take a look at the build logs.
Check if the failure is related to this commit (3d9692d) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/1460/builds/322

Failed tests:

test_pyrepl

Failed subtests:

test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/Users/ec2-user/buildbot/buildarea/3.13.itamaro-macos-intel-aws.macos-with-brew.asan.nogil/build/Lib/test/test_pyrepl/test_pyrepl.py", line 500, in test_stdout_is_tty
    if os.isatty(sys.stdout.fileno()):
                 ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno

bedevere-bot · 2024-07-17T15:53:49Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.x has failed when building commit ac07451.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/345/builds/8507) and take a look at the build logs.
Check if the failure is related to this commit (ac07451) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/345/builds/8507

Failed tests:

test_pyrepl

Failed subtests:

test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_pyrepl/test_pyrepl.py", line 500, in test_stdout_is_tty
    if os.isatty(sys.stdout.fileno()):
                 ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno

bedevere-bot · 2024-07-17T15:54:21Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86-64 MacOS Intel NoGIL 3.13 has failed when building commit 3d9692d.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/1449/builds/323) and take a look at the build logs.
Check if the failure is related to this commit (3d9692d) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/1449/builds/323

Failed tests:

test_pyrepl

Failed subtests:

test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/Users/ec2-user/buildbot/buildarea/3.13.itamaro-macos-intel-aws.nogil/build/Lib/test/test_pyrepl/test_pyrepl.py", line 500, in test_stdout_is_tty
    if os.isatty(sys.stdout.fileno()):
                 ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno

bedevere-bot · 2024-07-17T16:07:49Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 RHEL8 FIPS Only Blake2 Builtin Hash 3.x has failed when building commit ac07451.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/469/builds/8577) and take a look at the build logs.
Check if the failure is related to this commit (ac07451) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/469/builds/8577

Failed tests:

test_pyrepl

Failed subtests:

test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-fips-x86_64.no-builtin-hashes-except-blake2/build/Lib/test/test_pyrepl/test_pyrepl.py", line 500, in test_stdout_is_tty
    if os.isatty(sys.stdout.fileno()):
                 ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno

bedevere-bot · 2024-07-17T16:08:16Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows10 3.x has failed when building commit ac07451.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/146/builds/9086) and take a look at the build logs.
Check if the failure is related to this commit (ac07451) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/146/builds/9086

Failed tests:

test_pyrepl

Failed subtests:

test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\test_pyrepl\test_pyrepl.py", line 500, in test_stdout_is_tty
    if os.isatty(sys.stdout.fileno()):
                 ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno

bedevere-bot · 2024-07-17T16:24:17Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Ubuntu Shared 3.13 has failed when building commit 3d9692d.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/1450/builds/273) and take a look at the build logs.
Check if the failure is related to this commit (3d9692d) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/1450/builds/273

Failed tests:

test_pyrepl

Failed subtests:

test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.13.bolen-ubuntu/build/Lib/test/test_pyrepl/test_pyrepl.py", line 500, in test_stdout_is_tty
    if os.isatty(sys.stdout.fileno()):
                 ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno

bedevere-bot · 2024-07-17T16:41:24Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows10 3.13 has failed when building commit 3d9692d.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/1501/builds/301) and take a look at the build logs.
Check if the failure is related to this commit (3d9692d) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/1501/builds/301

Failed tests:

test_pyrepl

Failed subtests:

test_stdout_is_tty - test.test_pyrepl.test_pyrepl.TestPyReplOutput.test_stdout_is_tty

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "D:\buildarea\3.13.bolen-windows10\build\Lib\test\test_pyrepl\test_pyrepl.py", line 500, in test_stdout_is_tty
    if os.isatty(sys.stdout.fileno()):
                 ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno

pythongh-120678: pyrepl: Include globals from modules passed with -i

4dc6663

AlexWaygood added needs backport to 3.13 bugs and security fixes topic-repl Related to the interactive shell labels Jun 23, 2024

AlexWaygood requested review from pablogsal, lysnikolaou and ambv as code owners June 23, 2024 12:42

bedevere-app bot mentioned this pull request Jun 23, 2024

New REPL does not include globals from executed module when used with -i #120678

Closed

bedevere-app bot added the awaiting core review label Jun 23, 2024

eryksun approved these changes Jun 23, 2024

View reviewed changes

AlexWaygood added 3 commits June 26, 2024 11:01

Merge branch 'main' into repl-globals

03f04bf

nits

bc03ac0

further improve test

8c9a878

Merge branch 'main' into repl-globals

5af30e3

AlexWaygood and others added 3 commits June 26, 2024 21:17

Delete Lib/_pyrepl/_main.py

d1396b4

Merge branch 'main' into repl-globals

baacb0d

Ensure __file__, __package__, __name__, et al. behave correctly under -i

6bb7da5

ambv requested a review from ericsnowcurrently as a code owner July 17, 2024 13:08

ambv reviewed Jul 17, 2024

View reviewed changes

Lib/test/test_pyrepl/test_pyrepl.py Show resolved Hide resolved

ambv reviewed Jul 17, 2024

View reviewed changes

AlexWaygood commented Jul 17, 2024

View reviewed changes

Lib/test/test_pyrepl/test_pyrepl.py Show resolved Hide resolved

AlexWaygood commented Jul 17, 2024

View reviewed changes

Modules/main.c Outdated Show resolved Hide resolved

Appease the void

d3ba1e7

AlexWaygood commented Jul 17, 2024

View reviewed changes

Lib/test/test_pyrepl/test_pyrepl.py Show resolved Hide resolved

AlexWaygood commented Jul 17, 2024

View reviewed changes

ambv merged commit ac07451 into python:main Jul 17, 2024
44 checks passed

bedevere-app bot removed the awaiting core review label Jul 17, 2024

bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 17, 2024

AlexWaygood deleted the repl-globals branch July 17, 2024 15:22

This was referenced Jul 17, 2024

New buildbot failures: os.stdout.fileno() is unsupported #121927

Closed

gh-121927: Fix io.UnsupportedOperation: fileno exception in test_pyrepl #121928

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gh-120678: pyrepl: Include globals from modules passed with `-i` #120904

gh-120678: pyrepl: Include globals from modules passed with `-i` #120904

AlexWaygood commented Jun 23, 2024 •

edited

Loading

AlexWaygood commented Jun 23, 2024

eryksun left a comment

ambv commented Jun 26, 2024

ambv commented Jun 26, 2024 •

edited

Loading

ambv Jul 17, 2024

ambv Jul 17, 2024

AlexWaygood commented Jul 17, 2024

ambv commented Jul 17, 2024

AlexWaygood left a comment •

edited

Loading

miss-islington-app bot commented Jul 17, 2024

bedevere-app bot commented Jul 17, 2024

bedevere-bot commented Jul 17, 2024

bedevere-bot commented Jul 17, 2024

bedevere-bot commented Jul 17, 2024

bedevere-bot commented Jul 17, 2024

bedevere-bot commented Jul 17, 2024

bedevere-bot commented Jul 17, 2024

bedevere-bot commented Jul 17, 2024

bedevere-bot commented Jul 17, 2024

bedevere-bot commented Jul 17, 2024

bedevere-bot commented Jul 17, 2024

bedevere-bot commented Jul 17, 2024

bedevere-bot commented Jul 17, 2024

bedevere-bot commented Jul 17, 2024

bedevere-bot commented Jul 17, 2024

bedevere-bot commented Jul 17, 2024

bedevere-bot commented Jul 17, 2024

bedevere-bot commented Jul 17, 2024

bedevere-bot commented Jul 17, 2024

bedevere-bot commented Jul 17, 2024

bedevere-bot commented Jul 17, 2024

gh-120678: pyrepl: Include globals from modules passed with -i #120904

gh-120678: pyrepl: Include globals from modules passed with -i #120904

Conversation

AlexWaygood commented Jun 23, 2024 • edited Loading

AlexWaygood commented Jun 23, 2024

eryksun left a comment

Choose a reason for hiding this comment

ambv commented Jun 26, 2024

ambv commented Jun 26, 2024 • edited Loading

ambv Jul 17, 2024

Choose a reason for hiding this comment

ambv Jul 17, 2024

Choose a reason for hiding this comment

AlexWaygood commented Jul 17, 2024

ambv commented Jul 17, 2024

AlexWaygood left a comment • edited Loading

Choose a reason for hiding this comment

miss-islington-app bot commented Jul 17, 2024

bedevere-app bot commented Jul 17, 2024

bedevere-bot commented Jul 17, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jul 17, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jul 17, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jul 17, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jul 17, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jul 17, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jul 17, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jul 17, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jul 17, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jul 17, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jul 17, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jul 17, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jul 17, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jul 17, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jul 17, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jul 17, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jul 17, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jul 17, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jul 17, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jul 17, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

gh-120678: pyrepl: Include globals from modules passed with `-i` #120904

gh-120678: pyrepl: Include globals from modules passed with `-i` #120904

AlexWaygood commented Jun 23, 2024 •

edited

Loading

ambv commented Jun 26, 2024 •

edited

Loading

AlexWaygood left a comment •

edited

Loading