[3.12] gh-119897: Revert buggy optimization which was removed in 3.13 #120467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he generator is closed (python#118451)" This reverts commit 238efbe.
…GH-111069) (python#115818)" This reverts commit eb4774d.
|
Thanks for doing this! |
|
Is it worth adding a test for issue described in #119897? |
|
Does this need a news item? |
I'll add that in a separate PR to main. |
No, none of this stuff was in the news. |
Actually I'll add it here and then another PR for main and 3.13. |
iritkatriel
added a commit
to iritkatriel/cpython
that referenced
this pull request
Jun 17, 2024
markshannon
approved these changes
Jun 18, 2024
iritkatriel
added a commit
that referenced
this pull request
Jun 18, 2024
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 18, 2024
…20658) (cherry picked from commit 73dc1c6) Co-authored-by: Irit Katriel <[email protected]> pythongh-120467: Add test for lambda generator invocation
iritkatriel
added a commit
that referenced
this pull request
Jun 18, 2024
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
) pythongh-120467: Add test for lambda generator invocation
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
) pythongh-120467: Add test for lambda generator invocation
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
) pythongh-120467: Add test for lambda generator invocation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #120467.
Reverts #111069 and the followup #111459.
python: Objects/genobject.c:400: gen_close: Assertionexception_handler_depth > 0' failed.` #119897