gh-120343: Fix column offsets of multiline tokens in tokenize #120391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lysnikolaou
commented
Jun 12, 2024
•
lysnikolaou
commented
- Issue: Multiple lines f-string with non-ASCII breaks tokenize.generate_tokens in 3.12.4 #120343
lysnikolaou
added
skip news
needs backport to 3.12
|
Hummm, seems that this doesn't work as we still have some broken tests :( |
|
Oops. Fixed now. |
pablogsal
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
LGTM! Thanks for the fix @lysnikolaou
We want a NEWS entry probably, no?
|
The news entry in #120352 is probably good enough. What do you think? |
Agreed 👍 |
|
Thanks @lysnikolaou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 12, 2024
…ythonGH-120391) (cherry picked from commit 4b5d3e0) Co-authored-by: Lysandros Nikolaou <[email protected]>
|
GH-120427 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 12, 2024
…ythonGH-120391) (cherry picked from commit 4b5d3e0) Co-authored-by: Lysandros Nikolaou <[email protected]>
|
GH-120428 is a backport of this pull request to the 3.12 branch. |
lysnikolaou
added a commit
that referenced
this pull request
Jun 12, 2024
…H-120391) (#120428) (cherry picked from commit 4b5d3e0) Co-authored-by: Lysandros Nikolaou <[email protected]>
lysnikolaou
added a commit
that referenced
this pull request
Jun 12, 2024
…H-120391) (#120427) (cherry picked from commit 4b5d3e0) Co-authored-by: Lysandros Nikolaou <[email protected]>
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.