gh-119333: Add c-api to have contextvar enter/exit callbacks #119335
Conversation
There was a problem hiding this comment.
I'm OK with this change. The motivation for adding it seems reasonable. I'll let @ericsnowcurrently review it properly, but I skimmed through the code and I like the approach.
There was a problem hiding this comment.
Some minor remarks after a quick look: please align the naming with PEP-7 and use Py (not PY) prefixes for the macros.
|
@ericsnowcurrently Am I doing this wrong, Having an issue with Check if generated files are up to date I followed the example for the other watcher checks and they use the same style globals. Also I can't run the check locally it on my mac it doesn't seem to like clang. |
Try copying similar entries in Tools/c-analyzer/cpython/ignored.tsv and then editing them to match the new variables.
Yeah, sorry, this is definitely a gap. |
Co-authored-by: Erlend E. Aasland <[email protected]>
Co-authored-by: Erlend E. Aasland <[email protected]>
fried
force-pushed
the
pull-request-context-watchers
branch
from
e2fef0c
to
c210351
Compare
| static void notify_context_watchers(PyContextEvent event, PyContext *ctx) | ||
| { | ||
| assert(Py_REFCNT(ctx) > 0); | ||
| PyInterpreterState *interp = _PyInterpreterState_GET(); |
There was a problem hiding this comment.
FWIW you can get interp from tstate which is already known, it would have avoided one more tls read which is slow on msvc.
There was a problem hiding this comment.
Sorry. We’ll fix it tomorrow. Any other concerns?
| } PyContextEvent; | ||
|
|
||
| /* | ||
| * A Callback to clue in non-python contexts impls about a |
There was a problem hiding this comment.
I don't understand this comment, what is meant by clue in? Also what is change in active python context?
| * A Callback to clue in non-python contexts impls about a | ||
| * change in the active python context. | ||
| * | ||
| * The callback is invoked with the event and a reference to = |
There was a problem hiding this comment.
Remove the =, it adds no useful info and is confusing.
This PR implements gh-119333, allowing for setting a callback function on PyContext_Enter and PyContext_Exit from the c-api
Co-authored-by: @itamaro
📚 Documentation preview 📚: https://cpython-previews--119335.org.readthedocs.build/