Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-119180: Add LOAD_COMMON_CONSTANT opcode #119321

Merged
merged 7 commits into from
May 22, 2024
Merged

gh-119180: Add LOAD_COMMON_CONSTANT opcode #119321

merged 7 commits into from
May 22, 2024

Commits on May 21, 2024

  1. pythongh-119180: Add LOAD_COMMON_CONSTANT opcode 

    The PEP 649 implementation will require a way to load NotImplementedError
from the bytecode. @markshannon suggested implementing this by converting
LOAD_ASSERTION_ERROR into a more general mechanism for loading constants.

This PR adds this new opcode. I will work on the rest of the implementation
of the PEP separately.
    @JelleZijlstra
    JelleZijlstra committed May 21, 2024
    Configuration menu
    Copy the full SHA
    00d6eeb View commit details
    Browse the repository at this point in the history

  2. news

    @JelleZijlstra
    JelleZijlstra committed May 21, 2024
    Configuration menu
    Copy the full SHA
    983c93c View commit details
    Browse the repository at this point in the history

  3. Update Misc/NEWS.d/next/Core and Builtins/2024-05-21-12-17-02.gh-issu… 

    …e-119180.UNDUb9.rst

Co-authored-by: Irit Katriel <[email protected]>
    @JelleZijlstra @iritkatriel
    JelleZijlstra and iritkatriel authored May 21, 2024
    Configuration menu
    Copy the full SHA
    ab560cd View commit details
    Browse the repository at this point in the history

  4. Different way that should work on Windows

    @JelleZijlstra
    JelleZijlstra committed May 21, 2024
    Configuration menu
    Copy the full SHA
    4d42dcc View commit details
    Browse the repository at this point in the history

  5. Use a switch

    @JelleZijlstra
    JelleZijlstra committed May 21, 2024
    Configuration menu
    Copy the full SHA
    32a2a73 View commit details
    Browse the repository at this point in the history

  6. Update Misc/NEWS.d/next/Core and Builtins/2024-05-21-12-17-02.gh-issu… 

    …e-119180.UNDUb9.rst
    @JelleZijlstra
    JelleZijlstra authored May 21, 2024
    Configuration menu
    Copy the full SHA
    6c0514d View commit details
    Browse the repository at this point in the history

  7. Feedback from Guido

    @JelleZijlstra
    JelleZijlstra committed May 21, 2024
    Configuration menu
    Copy the full SHA
    d40a577 View commit details
    Browse the repository at this point in the history