Correct timing sensitivity in iOS testing Makefile target. #118620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SonicField
pushed a commit
to SonicField/cpython
that referenced
this pull request
May 8, 2024
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Aug 5, 2024
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Aug 5, 2024
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Aug 5, 2024
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Aug 5, 2024
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Sep 6, 2024
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Sep 9, 2024
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Sep 9, 2024
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Sep 9, 2024
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Sep 9, 2024
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI run 199 on the iOS buildbot failed because of a niche edge case: due to the specific time at which the test ran, the system clock ticked over a second between copying the built framework into the test folder, and starting the test.
This is a problem because
XCFOLDERis defined with=syntax, but also includes a dynamic$(shell)invocation. The use of=means the value is evaluated on use, rather than once at time of definition.This modifies the
Makefile.pre.into use:=syntax when creating the timestamp name; this ensures that the datestamp used in the build folder name is evaluated on definition, not use.