Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-118251: Skip tests not files in JIT CI #118536

Merged
merged 4 commits into from
May 3, 2024
Merged

gh-118251: Skip tests not files in JIT CI #118536

merged 4 commits into from
May 3, 2024

Conversation

savannahostrowski
Copy link
Member

@savannahostrowski savannahostrowski commented May 3, 2024 •
edited by bedevere-app bot
Loading

This PR moves jit.yml to reference an ignorefile as opposed to skipping entire files in CI.

Notes:

  • test_multiprocessing_fork - had to be wholly skipped to get things to pass
  • I am very flexible on file name and location. I dropped the ignorefile in Tools/jit for now since it was easier to deal with while testing since that dir is tracked in the workflow file. Happy to move it elsewhere if it makes more sense (e.g. in .github/workflows)
  • I also removed the exclude arg from other architectures since they aren't needed/being used.

@bedevere-app bedevere-app bot mentioned this pull request May 3, 2024
Closed
@savannahostrowski savannahostrowski changed the title gh-118251: Skip tests when running JIT CI gh-118251: Skip tests not files in JIT CI May 3, 2024
brandtbucher
brandtbucher reviewed May 3, 2024
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton, this really increases our test coverage for these builds! I'm happy keeping the file with the rest of the JIT stuff.

Can you also remove the --exclude from the Native Windows job? GitHub won't let me comment outside of the diff.

.github/workflows/jit.yml Outdated Show resolved Hide resolved
@brandtbucher brandtbucher self-assigned this May 3, 2024
@brandtbucher brandtbucher added tests Tests in the Lib/test dir skip news labels May 3, 2024
@brandtbucher brandtbucher enabled auto-merge (squash) May 3, 2024 18:53
@brandtbucher brandtbucher disabled auto-merge May 3, 2024 18:54
@brandtbucher brandtbucher enabled auto-merge (squash) May 3, 2024 18:54
@brandtbucher brandtbucher merged commit 5248596 into python:main May 3, 2024
56 of 58 checks passed
This was referenced May 3, 2024
Merged
Merged
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@savannahostrowski @SonicField
pythonGH-118251: Skip fewer test in emulated JIT CI (pythonGH-118536)
4670d66
@savannahostrowski savannahostrowski deleted the jit-skip-tests-ci branch September 27, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes

Assignees

@brandtbucher brandtbucher

Labels
skip news tests Tests in the Lib/test dir topic-JIT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@savannahostrowski @brandtbucher