Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-118082: Improve import without names syntax error message #118083

Merged
merged 5 commits into from
Apr 23, 2024
Merged

gh-118082: Improve import without names syntax error message #118083

merged 5 commits into from
Apr 23, 2024

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Apr 19, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Apr 19, 2024
Closed
@sobolevn
Copy link
Member Author

I've also added raw import support:

>>> import
  File "<stdin>", line 1
    import
          ^
SyntaxError: Expected one or more names after 'import'

@sobolevn sobolevn changed the title gh-118082: Improve from x import syntax error message gh-118082: Improve import without names syntax error message Apr 20, 2024
pablogsal
pablogsal approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Great work!

@pablogsal pablogsal merged commit de1f686 into python:main Apr 23, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eendebakpt eendebakpt eendebakpt left review comments

@pablogsal pablogsal pablogsal approved these changes

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolevn @eendebakpt @pablogsal