-
-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-117511: Make PyMutex public in the non-limited API #117731
Merged
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
3c743f8
gh-117511: Make PyMutex public in the non-limited API
colesbury d340d28
Add blurb
colesbury e59e0f7
Add missing newline
colesbury 1cef880
Replace `struct _PyMutex` with `PyMutex`
colesbury 28c90bc
Apply suggestions from code review
colesbury e321817
Update Doc/c-api/init.rst
colesbury 6533089
Use underscore prefix for PyMutex field.
colesbury 215020a
Fix comment
colesbury c0f75f9
PyMutex should not be copied or moved
colesbury 4ebc5e5
Merge branch 'main' into gh-117511-pymutex
colesbury 19a3492
Update documentation
colesbury 7230134
Export PyMutex_Lock and PyMutex_Unlock as regular functions
colesbury 6b2d377
Move PyMutex_Lock/Unlock definitions to end of file
colesbury 476e493
Update Doc/c-api/init.rst
vstinner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Replace
struct _PyMutex
with PyMutex
- Loading branch information
commit 1cef880f6229672ec7302b194eeb6e3822f0bea0
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is no public PyMutex_STATIC_INIT, can you maybe add a private one in pycore_lock.h?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's consider that in a separate PR:
PyEvent
,_PyOnceFlag
), not justPyMutex