Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-35878: Fix compiler warnings about end_col_offset and end_lineno #11735

Merged
merged 2 commits into from
Feb 10, 2019
Merged

bpo-35878: Fix compiler warnings about end_col_offset and end_lineno #11735

merged 2 commits into from
Feb 10, 2019

Conversation

ilevkivskyi
Copy link
Member

@ilevkivskyi ilevkivskyi commented Feb 2, 2019 •
edited by bedevere-bot
Loading

I think adding an assert there should be OK, since creating an empty suite is an error anyway and will likely crash later.

https://bugs.python.org/issue35878

eamanu
eamanu approved these changes Feb 4, 2019
View reviewed changes
Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ilevkivskyi
Copy link
Member Author

@vstinner Will you review this, or I can just merge it?

@ilevkivskyi
Copy link
Member Author

I am assuming this is good to go.

@ilevkivskyi ilevkivskyi merged commit 181835d into python:master Feb 10, 2019
@ilevkivskyi ilevkivskyi deleted the fix-compiler-ast-warning branch February 10, 2019 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eamanu eamanu eamanu approved these changes

@vstinner vstinner Awaiting requested review from vstinner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ilevkivskyi @eamanu @the-knights-who-say-ni @bedevere-bot