gh-56374: Clarify documentation of nonlocal #116942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redefine 'nonlocal scopes' in a way that excludes class scopes. Rearrange the rest of the doc. Add "Programmer's note".
terryjreedy
added
docs
terryjreedy
commented
Mar 18, 2024
zware
reviewed
Mar 18, 2024
terryjreedy
commented
Mar 18, 2024
|
The nonlocal page in doc preview looks ok. |
Eclips4
reviewed
Mar 18, 2024
terryjreedy
commented
Mar 19, 2024
Co-authored-by: Kirill Podoprigora <[email protected]>
|
Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 19, 2024
Define 'nonlocal scopes' in a way that excludes class scopes. Rearrange the rest of the doc. Add "Programmer's note". (cherry picked from commit 025ef7a) Co-authored-by: Terry Jan Reedy <[email protected]>
|
GH-117023 is a backport of this pull request to the 3.12 branch. |
|
Sorry, @terryjreedy, I could not cleanly backport this to |
|
Not worth manual backport. |
terryjreedy
pushed a commit
that referenced
this pull request
Mar 19, 2024
Define 'nonlocal scopes' in a way that excludes class scopes. Rearrange the rest of the doc. Add "Programmer's note". (cherry picked from commit 025ef7a) Co-authored-by: Terry Jan Reedy <[email protected]>
vstinner
pushed a commit
to vstinner/cpython
that referenced
this pull request
Mar 20, 2024
Define 'nonlocal scopes' in a way that excludes class scopes. Rearrange the rest of the doc. Add "Programmer's note".
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
Define 'nonlocal scopes' in a way that excludes class scopes. Rearrange the rest of the doc. Add "Programmer's note".
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
Define 'nonlocal scopes' in a way that excludes class scopes. Rearrange the rest of the doc. Add "Programmer's note".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define 'nonlocal scopes' first, and in a way that excludes class scopes.
Rearrange some of the doc. Add "Programmer's note".
📚 Documentation preview 📚: https://cpython-previews--116942.org.readthedocs.build/