Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-35800: Deprecate smtpd.MailmanProxy #11675

Merged
merged 4 commits into from
Oct 12, 2019
Merged

bpo-35800: Deprecate smtpd.MailmanProxy #11675

merged 4 commits into from
Oct 12, 2019

Conversation

samuelcolvin
Copy link
Sponsor Contributor

@samuelcolvin samuelcolvin commented Jan 25, 2019 •
edited by miss-islington
Loading

Since smtpd.MailmanProxy is already broken, it is not formally deprecated in 3.9. It will be removed in 3.10.

https://bugs.python.org/issue35800

Automerge-Triggered-By: @maxking

@samuelcolvin samuelcolvin requested a review from a team as a code owner January 25, 2019 17:15
@samuelcolvin samuelcolvin changed the title bpi-35800: deprecate MailmanProxy bpo-35800: deprecate MailmanProxy Jan 25, 2019
eamanu
eamanu reviewed Jan 28, 2019
View reviewed changes
Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this is a reasonable decision but (and how Barry Warsaw say) we should follow the normal deprecated process.

@samuelcolvin
Copy link
Sponsor Contributor Author

I tried to find docs on that but couldn't. Do you want two releases warning?

auvipy
auvipy suggested changes Feb 7, 2019
View reviewed changes
Doc/library/smtpd.rst Outdated Show resolved Hide resolved
@maxking
Copy link
Contributor

maxking commented Oct 6, 2019

Looks like we are past 3.8, let's move this to be deprecated in 3.9 and removed in 3.11.

@samuelcolvin can you please update it accordingly?

maxking
maxking requested changes Oct 6, 2019
View reviewed changes
Doc/library/smtpd.rst Outdated
@@ -148,6 +148,12 @@ MailmanProxy Objects

.. class:: MailmanProxy(localaddr, remoteaddr)

.. deprecated-removed:: 3.8 3.10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should now be 3.9 3.11 since we are past 3.8 period now.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@samuelcolvin
Copy link
Sponsor Contributor Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@maxking: please review the changes made to this pull request.

maxking
maxking approved these changes Oct 12, 2019
View reviewed changes
Copy link
Contributor

@maxking maxking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxking maxking changed the title bpo-35800: deprecate MailmanProxy bpo-35800: Deprecate smtpd.MailmanProxy Oct 12, 2019
@miss-islington miss-islington merged commit 822922a into python:master Oct 12, 2019
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@samuelcolvin
bpo-35800: Deprecate smtpd.MailmanProxy (pythonGH-11675)
b93825b 
Since `smtpd.MailmanProxy` is already broken, it is not formally deprecated in 3.9. It will be removed in 3.10.


https://bugs.python.org/issue35800
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eamanu eamanu eamanu left review comments

@auvipy auvipy auvipy requested changes

@maxking maxking maxking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@samuelcolvin @maxking @bedevere-bot @auvipy @eamanu @the-knights-who-say-ni @miss-islington