gh-116472: Fix invalid newlines in XML attr #116473
Conversation
Compliant XML readers normalize newlines in attributes to spaces (https://www.w3.org/TR/2006/REC-xml11-20060816/#AVNormalize). MSBuild apparently doesn't do that, but Python's minidom parser does. Android modifies this file with minidom (to include additional license texts from the dependencies we use) so the resulting file is re-written without the newlines, which breaks the build.
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Expecting that this is the case since it's only a problem if you're building Python in an unusual way. |
zooba
added
skip news
needs backport to 3.11
|
Happy to take this change, but also happy to accept changes that would let you inject extra license files somewhere else (either in your own .props file - as we can do to override externals versions/paths - or from the command line/environment). |
|
Thanks @DanAlbert for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
…SBuild files (pythonGH-116473) (cherry picked from commit 5d0cdfe) Co-authored-by: Dan Albert <[email protected]>
|
GH-116474 is a backport of this pull request to the 3.12 branch. |
…SBuild files (pythonGH-116473) (cherry picked from commit 5d0cdfe) Co-authored-by: Dan Albert <[email protected]>
|
GH-116475 is a backport of this pull request to the 3.11 branch. |
Yeah, that'd be better, but I'm an msbuild noob :) |
… files (GH-116473) (cherry picked from commit 5d0cdfe) Co-authored-by: Dan Albert <[email protected]>
… files (GH-116473) (cherry picked from commit 5d0cdfe) Co-authored-by: Dan Albert <[email protected]>
Compliant XML readers normalize newlines in attributes to spaces (https://www.w3.org/TR/2006/REC-xml11-20060816/#AVNormalize). MSBuild apparently doesn't do that, but Python's minidom parser does. Android modifies this file with minidom (to include additional license texts from the dependencies we use) so the resulting file is re-written without the newlines, which breaks the build.