Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-35794: Catch PermissionError in test_no_such_executable #11635

Merged
merged 1 commit into from
Jan 21, 2019
Merged

bpo-35794: Catch PermissionError in test_no_such_executable #11635

merged 1 commit into from
Jan 21, 2019

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Jan 21, 2019 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting merge labels Jan 21, 2019
vstinner
vstinner approved these changes Jan 21, 2019
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe just add proposed comment.

Lib/test/test_posix.py
@@ -1522,7 +1522,7 @@ def test_no_such_executable(self):
pid = self.spawn_func(no_such_executable,
[no_such_executable],
os.environ)
except FileNotFoundError as exc:
except (FileNotFoundError, PermissionError) as exc:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment mentioning bpo-35794 to explain why PermissionError is expected.

vstinner
vstinner reviewed Jan 21, 2019
View reviewed changes
Lib/test/test_posix.py Outdated
@@ -1522,7 +1522,9 @@ def test_no_such_executable(self):
pid = self.spawn_func(no_such_executable,
[no_such_executable],
os.environ)
except FileNotFoundError as exc:
# bpo-35794: PermissionError can be raised if there are
# directories in the $PATH that are not accesible.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: accessible?

Copy link
Member Author

@pablogsal pablogsal Jan 21, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wops! Fixed in last commit

@pablogsal pablogsal merged commit e9b185f into python:master Jan 21, 2019
@pablogsal pablogsal deleted the bpo35794 branch January 21, 2019 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pablogsal @vstinner @the-knights-who-say-ni @bedevere-bot