Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-116110: remove extra processing for the __signature__ attribute #116234

Merged
merged 1 commit into from
Oct 8, 2024
Merged

gh-116110: remove extra processing for the __signature__ attribute #116234

merged 1 commit into from
Oct 8, 2024
+19 −48

Conversation

skirpichev
Copy link
Member

@skirpichev skirpichev commented Mar 2, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Mar 2, 2024
Closed
ethanfurman
ethanfurman approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@ethanfurman ethanfurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this a lot better than my original solution.

@ethanfurman ethanfurman self-assigned this Oct 8, 2024
@ethanfurman ethanfurman added 3.14 new features, bugs and security fixes and removed DO-NOT-MERGE labels Oct 8, 2024
@ethanfurman ethanfurman merged commit eafd14f into python:main Oct 8, 2024
34 of 37 checks passed
@skirpichev skirpichev deleted the enum-signature-116110 branch October 9, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfurman ethanfurman ethanfurman approved these changes

Assignees

@ethanfurman ethanfurman

Labels
3.14 new features, bugs and security fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skirpichev @ethanfurman @merwok