Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.7] bpo-34323: Enhance IocpProactor.close() log #11565

Merged
merged 3 commits into from
Jan 15, 2019
Merged

[3.7] bpo-34323: Enhance IocpProactor.close() log #11565

merged 3 commits into from
Jan 15, 2019

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jan 15, 2019 •
edited
Loading

@vstinner
IocpProactor: prevent modification if closed (GH-11494)
1ad4dd3 
* _wait_for_handle(), _register() and _unregister() methods of
  IocpProactor now raise an exception if closed
* Add "closed" to IocpProactor.__repr__()
* Simplify IocpProactor.close()

(cherry picked from commit 9b07681)
@vstinner
bpo-34323: Enhance IocpProactor.close() log (GH-11555)
5d70012 
IocpProactor.close() now uses time to decide when to log: wait 1
second before the first log, then log every second. Log also the
number of seconds since close() was called.

(cherry picked from commit b1e4573)
@vstinner
bpo-11555: Enhance IocpProactor.close() log again (GH-11563)
56ac680 
Add repr(self) to the log to display the number of pending overlapped
in the log.

(cherry picked from commit b91140f)
@vstinner vstinner changed the title [3.7] bpo-11555: Enhance IocpProactor.close() log [3.7] bpo-34323: Enhance IocpProactor.close() log Jan 15, 2019
@vstinner vstinner merged commit d5a6adf into python:3.7 Jan 15, 2019
@vstinner vstinner deleted the proactor_log37 branch January 15, 2019 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @the-knights-who-say-ni @bedevere-bot