Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-112087: Make list_{concat, repeat, inplace_repeat, ass_item) to be thread-safe #115605

Merged
merged 7 commits into from
Feb 21, 2024
Merged

gh-112087: Make list_{concat, repeat, inplace_repeat, ass_item) to be thread-safe #115605

merged 7 commits into from
Feb 21, 2024

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Feb 17, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Feb 17, 2024
Closed
4 tasks
@corona10
Copy link
Member Author

corona10 commented Feb 17, 2024 •
edited
Loading

Two PRs will be left.

  1. list_ass_item and dependent APIs related changes: Quite huge; I will submit the change separately.
  2. QSBR-related changes. list_clear and list_new should use this technique.

colesbury
colesbury approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'd prefer we use consistent naming schemes for the functions that assume the callers hold the lock.

Objects/listobject.c Outdated Show resolved Hide resolved
@corona10 corona10 enabled auto-merge (squash) February 21, 2024 01:09
@corona10 corona10 merged commit 259730b into python:main Feb 21, 2024
33 checks passed
@corona10 corona10 deleted the gh-112087-part4 branch February 21, 2024 02:23
corona10 added a commit to corona10/cpython that referenced this pull request Feb 24, 2024
@corona10
pythongh-115605: Update list_new to follow nogil-3.12 build
32da182
corona10 added a commit to corona10/cpython that referenced this pull request Feb 24, 2024
@corona10
pythongh-115605 Use QSBR technique for list_new/free
de49474
corona10 added a commit to corona10/cpython that referenced this pull request Feb 28, 2024
@corona10
Merge remote-tracking branch 'upstream/main' into pythongh-115605-qsbr
0eb3657
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@corona10 @woodruffw
pythongh-112087: Make list_{concat, repeat, inplace_repeat, ass_item)…
e88a520 
… to be thread-safe (pythongh-115605)
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@corona10 @diegorusso
pythongh-112087: Make list_{concat, repeat, inplace_repeat, ass_item)…
5bb45d1 
… to be thread-safe (pythongh-115605)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesbury colesbury colesbury approved these changes

@mpage mpage Awaiting requested review from mpage

Assignees
No one assigned
Labels
skip news topic-free-threading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corona10 @colesbury