bpo-35699: fix distuils cannot detect Build Tools 2017 anymore #11495

schlamar · 2019-01-10T07:25:56Z

https://bugs.python.org/issue35699

zooba · 2019-01-11T04:51:59Z

@schlamar Looks great. We should have a NEWS entry for this - if you click "details" next to the failed check it'll provide instructions (basically, pip install blurb and add a message like "Fixed detection of Visual Studio Build Tools in distutils")

miss-islington · 2019-01-20T18:47:44Z

Thanks @schlamar for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

bedevere-bot · 2019-01-20T18:48:03Z

GH-11626 is a backport of this pull request to the 3.7 branch.

…nGH-11495) (cherry picked from commit b2dc4a3) Co-authored-by: Marc Schlaich <[email protected]>

) (cherry picked from commit b2dc4a3) Co-authored-by: Marc Schlaich <[email protected]>

bedevere-bot · 2019-01-21T10:34:28Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows7 SP1 3.x has failed when building commit b2dc4a3.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/40/builds/1524) and take a look at the build logs.
Check if the failure is related to this commit (b2dc4a3) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/40/builds/1524

Click to see traceback logs

Reset branch 'master'

Could Not Find C:\buildbot.python.org\3.x.kloth-win64\build\Lib\*.pyc
The system cannot find the file specified.
Could Not Find C:\buildbot.python.org\3.x.kloth-win64\build\PCbuild\python*.zip

test_zipfile64 skipped -- test requires loads of disk-space bytes and a long time to run
test_dbm_ndbm skipped -- No module named '_dbm'
minkernel\crts\ucrt\src\appcrt\lowio\write.cpp(50) : Assertion failed: (_osfile(fh) & FOPEN)
minkernel\crts\ucrt\src\appcrt\lowio\close.cpp(49) : Assertion failed: (_osfile(fh) & FOPEN)
minkernel\crts\ucrt\src\appcrt\lowio\close.cpp(49) : Assertion failed: (_osfile(fh) & FOPEN)
test_posix skipped -- No module named 'posix'
test_ioctl skipped -- No module named 'fcntl'
test_wait3 skipped -- os.fork not defined
test_resource skipped -- No module named 'resource'
test_xxtestfuzz skipped -- No module named '_xxtestfuzz'
test_getdata_filesys (test.test_pkgutil.PkgutilTests) ... ok
test_getdata_zipfile (test.test_pkgutil.PkgutilTests) ... ERROR
test_unreadable_dir_on_syspath (test.test_pkgutil.PkgutilTests) ... ok
test_walk_packages_raises_on_string_or_bytes_input (test.test_pkgutil.PkgutilTests) ... ok
test_walkpackages_filesys (test.test_pkgutil.PkgutilTests) ... ok
test_walkpackages_zipfile (test.test_pkgutil.PkgutilTests)
Tests the same as test_walkpackages_filesys, only with a zip file. ... ERROR
test_alreadyloaded (test.test_pkgutil.PkgutilPEP302Tests) ... ok
test_getdata_pep302 (test.test_pkgutil.PkgutilPEP302Tests) ... ok
test_iter_importers (test.test_pkgutil.ExtendPathTests) ... ok
test_mixed_namespace (test.test_pkgutil.ExtendPathTests) ... ok
test_simple (test.test_pkgutil.ExtendPathTests) ... ok
test_nested (test.test_pkgutil.NestedNamespacePackageTest) ... ok
test_find_loader_avoids_emulation (test.test_pkgutil.ImportlibMigrationTests) ... ok
test_find_loader_missing_module (test.test_pkgutil.ImportlibMigrationTests) ... ok
test_get_importer_avoids_emulation (test.test_pkgutil.ImportlibMigrationTests) ... ok
test_get_loader_None_in_sys_modules (test.test_pkgutil.ImportlibMigrationTests) ... ok
test_get_loader_avoids_emulation (test.test_pkgutil.ImportlibMigrationTests) ... ok
test_get_loader_handles_missing_loader_attribute (test.test_pkgutil.ImportlibMigrationTests) ... ok
test_get_loader_handles_missing_spec_attribute (test.test_pkgutil.ImportlibMigrationTests) ... ok
test_get_loader_handles_spec_attribute_none (test.test_pkgutil.ImportlibMigrationTests) ... ok
test_importer_deprecated (test.test_pkgutil.ImportlibMigrationTests) ... ok
test_iter_importers_avoids_emulation (test.test_pkgutil.ImportlibMigrationTests) ... ok
test_loader_deprecated (test.test_pkgutil.ImportlibMigrationTests) ... ok

======================================================================
ERROR: test_getdata_zipfile (test.test_pkgutil.PkgutilTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\shutil.py", line 681, in rmtree
    return _rmtree_unsafe(path, onerror)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\shutil.py", line 569, in _rmtree_unsafe
    onerror(os.rmdir, path, sys.exc_info())
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\shutil.py", line 567, in _rmtree_unsafe
    os.rmdir(path)
OSError: [WinError 145] The directory is not empty: 'C:\\Users\\Buildbot\\AppData\\Local\\Temp\\tmpz002lidp'

======================================================================
ERROR: test_walkpackages_zipfile (test.test_pkgutil.PkgutilTests)
Tests the same as test_walkpackages_filesys, only with a zip file.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\shutil.py", line 681, in rmtree
    return _rmtree_unsafe(path, onerror)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\shutil.py", line 569, in _rmtree_unsafe
    onerror(os.rmdir, path, sys.exc_info())
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\shutil.py", line 567, in _rmtree_unsafe
    os.rmdir(path)
OSError: [WinError 145] The directory is not empty: 'C:\\Users\\Buildbot\\AppData\\Local\\Temp\\tmplakdfec2'

----------------------------------------------------------------------

Ran 23 tests in 0.194s

FAILED (errors=2)
test test_pkgutil failed
test_tk skipped -- gui not available (WSF_VISIBLE flag not set)
test_crypt skipped -- No module named '_crypt'
test_pty skipped -- No module named 'termios'
test_pwd skipped -- No module named 'pwd'
test_tix skipped -- gui not available (WSF_VISIBLE flag not set)
test_poll skipped -- select.poll not defined
test_threadsignals skipped -- Can't test signal on win32
test_nis skipped -- No module named 'nis'
test_ossaudiodev skipped -- No module named 'ossaudiodev'
test_syslog skipped -- No module named 'syslog'
test_epoll skipped -- test works only on Linux 2.6
test_grp skipped -- No module named 'grp'
test_fork1 skipped -- object <module 'os' from 'C:\\buildbot.python.org\\3.x.kloth-win64\\build\\lib\\os.py'> has no attribute 'fork'
test_dbm_gnu skipped -- No module named '_gdbm'
test_gdb skipped -- Couldn't find gdb on the path
test_readline skipped -- No module named 'readline'
test_pipes skipped -- pipes module only works on posix
test_wait4 skipped -- object <module 'os' from 'C:\\buildbot.python.org\\3.x.kloth-win64\\build\\lib\\os.py'> has no attribute 'fork'
minkernel\crts\ucrt\src\appcrt\lowio\write.cpp(50) : Assertion failed: (_osfile(fh) & FOPEN)
test_devpoll skipped -- test works only on Solaris OS family
test_fcntl skipped -- No module named 'fcntl'
testAFakeZlib (test.test_zipimport.UncompressedZipImportTestCase) ... skipped 'zlib is a builtin module'
testBadMTime (test.test_zipimport.UncompressedZipImportTestCase) ... ok
testBadMagic (test.test_zipimport.UncompressedZipImportTestCase) ... ok
testBadMagic2 (test.test_zipimport.UncompressedZipImportTestCase) ... ok
testBeginningCruftAndComment (test.test_zipimport.UncompressedZipImportTestCase) ... ok
testBoth (test.test_zipimport.UncompressedZipImportTestCase) ... ok
testBytesPath (test.test_zipimport.UncompressedZipImportTestCase) ... ok
testComment (test.test_zipimport.UncompressedZipImportTestCase) ... ok
testDefaultOptimizationLevel (test.test_zipimport.UncompressedZipImportTestCase) ... ok
testDoctestFile (test.test_zipimport.UncompressedZipImportTestCase) ... ok
testDoctestSuite (test.test_zipimport.UncompressedZipImportTestCase) ... ok
testEmptyPy (test.test_zipimport.UncompressedZipImportTestCase) ... ok
testGetCompiledSource (test.test_zipimport.UncompressedZipImportTestCase) ... ok
testGetData (test.test_zipimport.UncompressedZipImportTestCase) ... ok
testGetSource (test.test_zipimport.UncompressedZipImportTestCase) ... ERROR
ERROR
testImport_WithStuff (test.test_zipimport.UncompressedZipImportTestCase) ... ERROR
ERROR
testImporterAttr (test.test_zipimport.UncompressedZipImportTestCase) ... ERROR
ERROR
testLargestPossibleComment (test.test_zipimport.UncompressedZipImportTestCase) ... ERROR
ERROR
testMixedNamespacePackage (test.test_zipimport.UncompressedZipImportTestCase) ... ok
testNamespacePackage (test.test_zipimport.UncompressedZipImportTestCase) ... ok
testPackage (test.test_zipimport.UncompressedZipImportTestCase) ... ok
testPy (test.test_zipimport.UncompressedZipImportTestCase) ... ok
testPyc (test.test_zipimport.UncompressedZipImportTestCase) ... ok
testSubNamespacePackage (test.test_zipimport.UncompressedZipImportTestCase) ... ok
testSubPackage (test.test_zipimport.UncompressedZipImportTestCase) ... ok
testTraceback (test.test_zipimport.UncompressedZipImportTestCase) ... ok
testUncheckedHashBasedPyc (test.test_zipimport.UncompressedZipImportTestCase) ... ok
testUnencodable (test.test_zipimport.UncompressedZipImportTestCase) ... ok
testZipImporterMethods (test.test_zipimport.UncompressedZipImportTestCase) ... ok
testZipImporterMethodsInSubDirectory (test.test_zipimport.UncompressedZipImportTestCase) ... ok
testAFakeZlib (test.test_zipimport.CompressedZipImportTestCase) ... skipped 'zlib is a builtin module'
testBadMTime (test.test_zipimport.CompressedZipImportTestCase) ... ERROR
ERROR
testBadMagic (test.test_zipimport.CompressedZipImportTestCase) ... ERROR
ERROR
testBadMagic2 (test.test_zipimport.CompressedZipImportTestCase) ... ERROR
ERROR
testBeginningCruftAndComment (test.test_zipimport.CompressedZipImportTestCase) ... ok
testBoth (test.test_zipimport.CompressedZipImportTestCase) ... ok
testBytesPath (test.test_zipimport.CompressedZipImportTestCase) ... ok
testComment (test.test_zipimport.CompressedZipImportTestCase) ... ok
testDefaultOptimizationLevel (test.test_zipimport.CompressedZipImportTestCase) ... ok
testDoctestFile (test.test_zipimport.CompressedZipImportTestCase) ... ok
testDoctestSuite (test.test_zipimport.CompressedZipImportTestCase) ... ok
testEmptyPy (test.test_zipimport.CompressedZipImportTestCase) ... ok
testGetCompiledSource (test.test_zipimport.CompressedZipImportTestCase) ... ok
testGetData (test.test_zipimport.CompressedZipImportTestCase) ... ok
testGetSource (test.test_zipimport.CompressedZipImportTestCase) ... ok
testImport_WithStuff (test.test_zipimport.CompressedZipImportTestCase) ... ok
testImporterAttr (test.test_zipimport.CompressedZipImportTestCase) ... ok
testLargestPossibleComment (test.test_zipimport.CompressedZipImportTestCase) ... ok
testMixedNamespacePackage (test.test_zipimport.CompressedZipImportTestCase) ... ok
testNamespacePackage (test.test_zipimport.CompressedZipImportTestCase) ... ok
testPackage (test.test_zipimport.CompressedZipImportTestCase) ... ok
testPy (test.test_zipimport.CompressedZipImportTestCase) ... ok
testPyc (test.test_zipimport.CompressedZipImportTestCase) ... ok
testSubNamespacePackage (test.test_zipimport.CompressedZipImportTestCase) ... ok
testSubPackage (test.test_zipimport.CompressedZipImportTestCase) ... ok
testTraceback (test.test_zipimport.CompressedZipImportTestCase) ... ok
testUncheckedHashBasedPyc (test.test_zipimport.CompressedZipImportTestCase) ... ok
testUnencodable (test.test_zipimport.CompressedZipImportTestCase) ... ok
testZipImporterMethods (test.test_zipimport.CompressedZipImportTestCase) ... ok
testZipImporterMethodsInSubDirectory (test.test_zipimport.CompressedZipImportTestCase) ... ok
testBadArgs (test.test_zipimport.BadFileZipImportTestCase) ... ok
testEmptyFile (test.test_zipimport.BadFileZipImportTestCase) ... ok
testEmptyFilename (test.test_zipimport.BadFileZipImportTestCase) ... ok
testFileUnreadable (test.test_zipimport.BadFileZipImportTestCase) ... ok
testFilenameTooLong (test.test_zipimport.BadFileZipImportTestCase) ... ok
testNoFile (test.test_zipimport.BadFileZipImportTestCase) ... ok
testNotZipFile (test.test_zipimport.BadFileZipImportTestCase) ... ok

======================================================================
ERROR: testGetSource (test.test_zipimport.UncompressedZipImportTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\test_zipimport.py", line 581, in testGetSource
    self.doTest(".py", files, TESTMOD, call=self.assertModuleSource)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\test_zipimport.py", line 133, in doTest
    self.makeZip(files, **kw)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\test_zipimport.py", line 114, in makeZip
    with ZipFile(zipName, "w") as z:
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\zipfile.py", line 1209, in __init__
    self.fp = io.open(file, filemode)
PermissionError: [Errno 13] Permission denied: 'C:\\buildbot.python.org\\3.x.kloth-win64\\build\\build\\test_python_4816\\junk95142.zip'

======================================================================
ERROR: testGetSource (test.test_zipimport.UncompressedZipImportTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\support\__init__.py", line 438, in unlink
    _unlink(filename)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\support\__init__.py", line 371, in _unlink
    _waitfor(os.unlink, filename)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\support\__init__.py", line 339, in _waitfor
    func(pathname)
PermissionError: [WinError 5] Access is denied: 'C:\\buildbot.python.org\\3.x.kloth-win64\\build\\build\\test_python_4816\\junk95142.zip'

======================================================================
ERROR: testImport_WithStuff (test.test_zipimport.UncompressedZipImportTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\test_zipimport.py", line 573, in testImport_WithStuff
    self.doTest(".py", files, TESTMOD,
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\test_zipimport.py", line 133, in doTest
    self.makeZip(files, **kw)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\test_zipimport.py", line 114, in makeZip
    with ZipFile(zipName, "w") as z:
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\zipfile.py", line 1209, in __init__
    self.fp = io.open(file, filemode)
PermissionError: [Errno 13] Permission denied: 'C:\\buildbot.python.org\\3.x.kloth-win64\\build\\build\\test_python_4816\\junk95142.zip'

======================================================================
ERROR: testImport_WithStuff (test.test_zipimport.UncompressedZipImportTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\support\__init__.py", line 438, in unlink
    _unlink(filename)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\support\__init__.py", line 371, in _unlink
    _waitfor(os.unlink, filename)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\support\__init__.py", line 339, in _waitfor
    func(pathname)
PermissionError: [WinError 5] Access is denied: 'C:\\buildbot.python.org\\3.x.kloth-win64\\build\\build\\test_python_4816\\junk95142.zip'

======================================================================
ERROR: testImporterAttr (test.test_zipimport.UncompressedZipImportTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\test_zipimport.py", line 554, in testImporterAttr
    self.doTest(pyc_ext, files, TESTMOD)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\test_zipimport.py", line 133, in doTest
    self.makeZip(files, **kw)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\test_zipimport.py", line 114, in makeZip
    with ZipFile(zipName, "w") as z:
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\zipfile.py", line 1209, in __init__
    self.fp = io.open(file, filemode)
PermissionError: [Errno 13] Permission denied: 'C:\\buildbot.python.org\\3.x.kloth-win64\\build\\build\\test_python_4816\\junk95142.zip'

======================================================================
ERROR: testImporterAttr (test.test_zipimport.UncompressedZipImportTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\support\__init__.py", line 438, in unlink
    _unlink(filename)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\support\__init__.py", line 371, in _unlink
    _waitfor(os.unlink, filename)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\support\__init__.py", line 339, in _waitfor
    func(pathname)
PermissionError: [WinError 5] Access is denied: 'C:\\buildbot.python.org\\3.x.kloth-win64\\build\\build\\test_python_4816\\junk95142.zip'

======================================================================
ERROR: testLargestPossibleComment (test.test_zipimport.UncompressedZipImportTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\test_zipimport.py", line 681, in testLargestPossibleComment
    self.doTest(".py", files, TESTMOD, comment=b"c" * ((1 << 16) - 1))
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\test_zipimport.py", line 133, in doTest
    self.makeZip(files, **kw)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\test_zipimport.py", line 114, in makeZip
    with ZipFile(zipName, "w") as z:
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\zipfile.py", line 1209, in __init__
    self.fp = io.open(file, filemode)
PermissionError: [Errno 13] Permission denied: 'C:\\buildbot.python.org\\3.x.kloth-win64\\build\\build\\test_python_4816\\junk95142.zip'

======================================================================
ERROR: testLargestPossibleComment (test.test_zipimport.UncompressedZipImportTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\support\__init__.py", line 438, in unlink
    _unlink(filename)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\support\__init__.py", line 371, in _unlink
    _waitfor(os.unlink, filename)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\support\__init__.py", line 339, in _waitfor
    func(pathname)
PermissionError: [WinError 5] Access is denied: 'C:\\buildbot.python.org\\3.x.kloth-win64\\build\\build\\test_python_4816\\junk95142.zip'

======================================================================
ERROR: testBadMTime (test.test_zipimport.CompressedZipImportTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\test_zipimport.py", line 238, in testBadMTime
    self.doTest(".py", files, TESTMOD)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\test_zipimport.py", line 133, in doTest
    self.makeZip(files, **kw)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\test_zipimport.py", line 114, in makeZip
    with ZipFile(zipName, "w") as z:
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\zipfile.py", line 1209, in __init__
    self.fp = io.open(file, filemode)
PermissionError: [Errno 13] Permission denied: 'C:\\buildbot.python.org\\3.x.kloth-win64\\build\\build\\test_python_4816\\junk95142.zip'

======================================================================
ERROR: testBadMTime (test.test_zipimport.CompressedZipImportTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\support\__init__.py", line 438, in unlink
    _unlink(filename)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\support\__init__.py", line 371, in _unlink
    _waitfor(os.unlink, filename)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\support\__init__.py", line 339, in _waitfor
    func(pathname)
PermissionError: [WinError 5] Access is denied: 'C:\\buildbot.python.org\\3.x.kloth-win64\\build\\build\\test_python_4816\\junk95142.zip'

======================================================================
ERROR: testBadMagic (test.test_zipimport.CompressedZipImportTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\test_zipimport.py", line 217, in testBadMagic
    self.doTest(".py", files, TESTMOD)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\test_zipimport.py", line 133, in doTest
    self.makeZip(files, **kw)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\test_zipimport.py", line 114, in makeZip
    with ZipFile(zipName, "w") as z:
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\zipfile.py", line 1209, in __init__
    self.fp = io.open(file, filemode)
PermissionError: [Errno 13] Permission denied: 'C:\\buildbot.python.org\\3.x.kloth-win64\\build\\build\\test_python_4816\\junk95142.zip'

======================================================================
ERROR: testBadMagic (test.test_zipimport.CompressedZipImportTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\support\__init__.py", line 438, in unlink
    _unlink(filename)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\support\__init__.py", line 371, in _unlink
    _waitfor(os.unlink, filename)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\support\__init__.py", line 339, in _waitfor
    func(pathname)
PermissionError: [WinError 5] Access is denied: 'C:\\buildbot.python.org\\3.x.kloth-win64\\build\\build\\test_python_4816\\junk95142.zip'

======================================================================
ERROR: testBadMagic2 (test.test_zipimport.CompressedZipImportTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\test_zipimport.py", line 225, in testBadMagic2
    self.doTest(".py", files, TESTMOD)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\test_zipimport.py", line 133, in doTest
    self.makeZip(files, **kw)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\test_zipimport.py", line 114, in makeZip
    with ZipFile(zipName, "w") as z:
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\zipfile.py", line 1209, in __init__
    self.fp = io.open(file, filemode)
PermissionError: [Errno 13] Permission denied: 'C:\\buildbot.python.org\\3.x.kloth-win64\\build\\build\\test_python_4816\\junk95142.zip'

======================================================================
ERROR: testBadMagic2 (test.test_zipimport.CompressedZipImportTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\support\__init__.py", line 438, in unlink
    _unlink(filename)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\support\__init__.py", line 371, in _unlink
    _waitfor(os.unlink, filename)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\support\__init__.py", line 339, in _waitfor
    func(pathname)
PermissionError: [WinError 5] Access is denied: 'C:\\buildbot.python.org\\3.x.kloth-win64\\build\\build\\test_python_4816\\junk95142.zip'

----------------------------------------------------------------------

Ran 67 tests in 0.619s

FAILED (errors=14, skipped=2)
test test_zipimport failed
test_multiprocessing_forkserver skipped -- forkserver is not available on Windows
test_openpty skipped -- os.openpty() not available.
test_multiprocessing_fork skipped -- fork is not available on Windows
test_kqueue skipped -- test works only on BSD
test_ttk_guionly skipped -- gui not available (WSF_VISIBLE flag not set)
test_spwd skipped -- No module named 'spwd'
test_cmdline_copy (test.test_zipapp.ZipAppCmdlineTest) ... ok
test_cmdline_copy_change_main (test.test_zipapp.ZipAppCmdlineTest) ... ok
test_cmdline_copy_inplace (test.test_zipapp.ZipAppCmdlineTest) ... ok
test_cmdline_create (test.test_zipapp.ZipAppCmdlineTest) ... ok
test_info_command (test.test_zipapp.ZipAppCmdlineTest) ... ok
test_info_error (test.test_zipapp.ZipAppCmdlineTest) ... ok
test_content_of_copied_archive (test.test_zipapp.ZipAppTest) ... ok
test_create_archive (test.test_zipapp.ZipAppTest) ... ok
test_create_archive_default_target (test.test_zipapp.ZipAppTest) ... ok
test_create_archive_filter_exclude_dir (test.test_zipapp.ZipAppTest) ... ERROR
test_create_archive_with_compression (test.test_zipapp.ZipAppTest) ... ERROR
test_create_archive_with_filter (test.test_zipapp.ZipAppTest) ... ok
test_create_archive_with_pathlib (test.test_zipapp.ZipAppTest) ... ok
test_create_archive_with_subdirs (test.test_zipapp.ZipAppTest) ... ok
test_custom_interpreter (test.test_zipapp.ZipAppTest) ... ok
test_default_no_shebang (test.test_zipapp.ZipAppTest) ... ok
test_main_and_main_py (test.test_zipapp.ZipAppTest) ... ok
test_main_only_written_once (test.test_zipapp.ZipAppTest) ... ERROR
test_main_validation (test.test_zipapp.ZipAppTest) ... ok
test_main_written (test.test_zipapp.ZipAppTest) ... ok
test_modify_shebang (test.test_zipapp.ZipAppTest) ... ok
test_no_main (test.test_zipapp.ZipAppTest) ... ok
test_no_shebang_is_not_executable (test.test_zipapp.ZipAppTest) ... skipped 'Windows does not support an executable bit'
test_pack_to_fileobj (test.test_zipapp.ZipAppTest) ... ok
test_read_from_fileobj (test.test_zipapp.ZipAppTest) ... ok
test_read_from_pathobj (test.test_zipapp.ZipAppTest) ... ok
test_read_missing_shebang (test.test_zipapp.ZipAppTest) ... ok
test_read_shebang (test.test_zipapp.ZipAppTest) ... ok
test_remove_shebang (test.test_zipapp.ZipAppTest) ... ok
test_shebang_is_executable (test.test_zipapp.ZipAppTest) ... skipped 'Windows does not support an executable bit'
test_write_shebang_to_fileobj (test.test_zipapp.ZipAppTest) ... ok

======================================================================
ERROR: test_create_archive_filter_exclude_dir (test.test_zipapp.ZipAppTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\tempfile.py", line 806, in cleanup
    _shutil.rmtree(self.name)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\shutil.py", line 681, in rmtree
    return _rmtree_unsafe(path, onerror)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\shutil.py", line 569, in _rmtree_unsafe
    onerror(os.rmdir, path, sys.exc_info())
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\shutil.py", line 567, in _rmtree_unsafe
    os.rmdir(path)
OSError: [WinError 145] The directory is not empty: 'C:\\Users\\Buildbot\\AppData\\Local\\Temp\\tmpy66jew29'

======================================================================
ERROR: test_create_archive_with_compression (test.test_zipapp.ZipAppTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\tempfile.py", line 806, in cleanup
    _shutil.rmtree(self.name)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\shutil.py", line 681, in rmtree
    return _rmtree_unsafe(path, onerror)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\shutil.py", line 569, in _rmtree_unsafe
    onerror(os.rmdir, path, sys.exc_info())
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\shutil.py", line 567, in _rmtree_unsafe
    os.rmdir(path)
OSError: [WinError 145] The directory is not empty: 'C:\\Users\\Buildbot\\AppData\\Local\\Temp\\tmpdmtiiicu'

======================================================================
ERROR: test_main_only_written_once (test.test_zipapp.ZipAppTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\tempfile.py", line 806, in cleanup
    _shutil.rmtree(self.name)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\shutil.py", line 681, in rmtree
    return _rmtree_unsafe(path, onerror)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\shutil.py", line 569, in _rmtree_unsafe
    onerror(os.rmdir, path, sys.exc_info())
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\shutil.py", line 567, in _rmtree_unsafe
    os.rmdir(path)
OSError: [WinError 145] The directory is not empty: 'C:\\Users\\Buildbot\\AppData\\Local\\Temp\\tmpo7br9aeo'

----------------------------------------------------------------------

Ran 31 tests in 0.190s

FAILED (errors=3, skipped=2)
test test_zipapp failed
test_curses skipped -- No module named '_curses'
test test_pkgutil failed

Could Not Find C:\buildbot.python.org\3.x.kloth-win64\build\PCbuild\python*.zip

bpo-35699: fix distuils cannot detect Build Tools 2017 anymore

7e7e5da

the-knights-who-say-ni added the CLA signed label Jan 10, 2019

bedevere-bot added the awaiting review label Jan 10, 2019

zooba added OS-windows needs backport to 3.7 type-bug An unexpected behavior, bug, or error labels Jan 11, 2019

📜🤖 Added by blurb_it.

3fa0b55

ned-deily merged commit b2dc4a3 into python:master Jan 20, 2019

bedevere-bot removed the awaiting review label Jan 20, 2019

bedevere-bot removed the needs backport to 3.7 label Jan 20, 2019

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 20, 2019

bpo-35699: fix distuils cannot detect Build Tools 2017 anymore (pytho…

1869df6

…nGH-11495) (cherry picked from commit b2dc4a3) Co-authored-by: Marc Schlaich <[email protected]>

miss-islington added a commit that referenced this pull request Jan 20, 2019

bpo-35699: fix distuils cannot detect Build Tools 2017 anymore (GH-11495

2fa53cf

) (cherry picked from commit b2dc4a3) Co-authored-by: Marc Schlaich <[email protected]>

schlamar deleted the patch-1 branch January 21, 2019 10:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bpo-35699: fix distuils cannot detect Build Tools 2017 anymore #11495

bpo-35699: fix distuils cannot detect Build Tools 2017 anymore #11495

schlamar commented Jan 10, 2019 •

edited by bedevere-bot

Loading

zooba commented Jan 11, 2019

miss-islington commented Jan 20, 2019

bedevere-bot commented Jan 20, 2019

bedevere-bot commented Jan 21, 2019

bpo-35699: fix distuils cannot detect Build Tools 2017 anymore #11495

bpo-35699: fix distuils cannot detect Build Tools 2017 anymore #11495

Conversation

schlamar commented Jan 10, 2019 • edited by bedevere-bot Loading

zooba commented Jan 11, 2019

miss-islington commented Jan 20, 2019

bedevere-bot commented Jan 20, 2019

bedevere-bot commented Jan 21, 2019

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

schlamar commented Jan 10, 2019 •

edited by bedevere-bot

Loading