Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-100734: What's New in 3.x: Add missing detail from 3.x branch #114689

Merged
merged 8 commits into from
Feb 15, 2024

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jan 28, 2024

Fixes #100734.

Add missing details to "What's New in Python 3.x?" from the corresponding version branch.

3.11 was done in PR #114657.

Only went as far back as 2.6; the docs in 2.0-2.5 are .tex and not .rst!

Where the original had :issue:`xxxxx`, I replaced with the matching :gh:`yyyyy` to future-proof and save a redirect.


📚 Documentation preview 📚: https://cpython-previews--114689.org.readthedocs.build/

Notable security feature in 3.10.8
==================================

The deprecated :mod:`!mailcap` module now refuses to inject unsafe text
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: mailcap was removed in 3.13, so we don't need to silence this with ! in the 3.12 and 3.11 backports.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it alright to leave it rather than create a separate 3.12 PR unless you want to.

@terryjreedy
Copy link
Member

The main issue seems to be that when new features are added to a 3.x.y bugfix releases, the change is added directly to What's New 3.x in the 3.x version instead of the main version and backported. I assume the additions are correct, without going back and checking. What review, if any, would you like?

@hugovk
Copy link
Member Author

hugovk commented Feb 1, 2024

The main issue seems to be that when new features are added to a 3.x.y bugfix releases, the change is added directly to What's New 3.x in the 3.x version instead of the main version and backported. I assume the additions are correct, without going back and checking.

That's right, I compared whatsnew/3.12.rst between the 3.12 branch and main, and added missing bits from the 3.12 branch to main.

Then repeated for whatsnew/3.11.rst between the 3.11 branch and main, and repeat down to 2.6.

What review, if any, would you like?

I guess just a check there's nothing completely out of place?

@hugovk hugovk merged commit cfb2640 into python:main Feb 15, 2024
29 checks passed
@hugovk hugovk deleted the sync-whatsnew branch February 15, 2024 15:32
@miss-islington-app
Copy link

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 15, 2024
@miss-islington-app
Copy link

Sorry, @hugovk, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker cfb26401f60a428b3674eb5d9eecf315eb55acab 3.11

@bedevere-app
Copy link

bedevere-app bot commented Feb 15, 2024

GH-115526 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Feb 15, 2024
@bedevere-app
Copy link

bedevere-app bot commented Feb 15, 2024

GH-115527 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Feb 15, 2024
hugovk added a commit to hugovk/cpython that referenced this pull request Feb 15, 2024
…x branch (pythonGH-114689).

(cherry picked from commit cfb2640)

Co-authored-by: Hugo van Kemenade <[email protected]>
@hugovk
Copy link
Member Author

hugovk commented Feb 15, 2024

GH-115526 is a backport of this pull request to the 3.12 branch.

hugovk added a commit that referenced this pull request Feb 15, 2024
Fhhfhpp

This comment was marked as spam.

diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc/whatsnew/3.{9,10,11}.rst are out of sync on various branches
3 participants