Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo #11468

Closed
wants to merge 1 commit into from
Closed

fix typo #11468

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 8, 2019

"implictly" sould be "implicitly"

"implictly" sould be "implicitly"
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@tirkarthi
Copy link
Member

The PR needs to be raised against master branch which has the typo and will be backported to 3.7 . I am not sure if typo fix requires a CLA though.

Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix typo is correct. But this need to be doing on master

@ghost ghost mentioned this pull request Jan 8, 2019
@ghost
Copy link
Author

ghost commented Jan 8, 2019

I created a PR (#11470) on master, like you said.
Looks like I need to wait for the CLA.

@ghost ghost closed this Jan 8, 2019
@ghost ghost deleted the patch-1 branch January 8, 2019 14:26
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting core review docs Documentation in the Doc dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants